Export to GitHub

oauth - issue #64

rsa.py module should not consider consumer secret as a part of the signature base string.


Posted on Nov 17, 2008 by Swift Cat

What steps will reproduce the problem? 1. If you try to use the signature method RSA-SHA1, by using the rsa.py module without providing a consumer secret i.e. if consumer_secret=None, build_signature_base_string method will throw an error (TyprError: argument 2 to map() must support iteration).

For using signature method RSA-SHA1, providing a consumer secret should not be compulsory, it should be optional. It should not matter whether consumer secret is included in the signature base string or not. In the current code, consumer secret has to be present which is wrong.

Please fix this as soon as possible. Please see the attached diff file.

Attachments

Comment #1

Posted on Nov 19, 2008 by Swift Cat

Please disregard the previous rsa.diff. In addition to the consumer secret, the token secret too should not be considered. So the present code won't work if the token does not have a secret or there is no consumer secret which is incorrect. Please find the new rsa.diff attached.

Attachments

Comment #2

Posted on Jan 14, 2009 by Helpful Bear

Andy - can yo take a look at this?

Status: New

Labels:
Type-Defect Priority-Medium Lib-Python