Last 30 days

• Dec 07, 2009

  r145 (Overrode OAuthRequestException.ToString to contain additiona...) committed by bruceboughton   -   Overrode OAuthRequestException.ToString to contain additional data

  Overrode OAuthRequestException.ToString to contain additional data
• Dec 02, 2009

  r144 (Fixed cloning of AdditionalParameters) committed by bruceboughton   -   Fixed cloning of AdditionalParameters

  Fixed cloning of AdditionalParameters

Earlier this year

• Nov 13, 2009

  r143 (Fix for doubled up query string arguments when fetching a pr...) committed by bruceboughton   -   Fix for doubled up query string arguments when fetching a protected resource URI with query string arguments

  Fix for doubled up query string arguments when fetching a protected resource URI with query string arguments
• Oct 20, 2009

  issue 21 (OAuth.Net.Examples.TwitterClient fails on cultures other tha...) reported by bartlomiej.szafko   -   Running OAuth.Net.Examples.TwitterClient on culture other than en-us (pl-PL) causes FormatException on DateTime.ParseExact. The solution is to change ExtendedUser.cs lines 088 and 089: this.CreatedDate = DateTime .ParseExact(value, TwitterApi.DateFormat, CultureInfo.InvariantCulture); same modifictaion is required i Status.cs. I attached a patch to current trunk rev 142

  Running OAuth.Net.Examples.TwitterClient on culture other than en-us (pl-PL) causes FormatException on DateTime.ParseExact. The solution is to change ExtendedUser.cs lines 088 and 089: this.CreatedDate = DateTime .ParseExact(value, TwitterApi.DateFormat, CultureInfo.InvariantCulture); same modifictaion is required i Status.cs. I attached a patch to current trunk rev 142
• Oct 01, 2009

  r142 (Added request state store for managing the state of consumer...) committed by bruceboughton   -   Added request state store for managing the state of consumer requests; Added AspNetOAuthRequest for configuring consumer requests for a typical ASP.NET environment; Updated example apps to use new APIs

  Added request state store for managing the state of consumer requests; Added AspNetOAuthRequest for configuring consumer requests for a typical ASP.NET environment; Updated example apps to use new APIs
• Oct 01, 2009

  r141 (Changed how the body of a response handles text sent down. ...) committed by chris.s.adams   -   Changed how the body of a response handles text sent down. If it isn't parse able into a name value collection then the full content is added into as an OAuthRequestExtensionParameters.Problem

  Changed how the body of a response handles text sent down. If it isn't parse able into a name value collection then the full content is added into as an OAuthRequestExtensionParameters.Problem
• Sep 29, 2009

  r140 (Removed OAuthService.CallbackUrl and replaced it with OAuthR...) committed by bruceboughton   -   Removed OAuthService.CallbackUrl and replaced it with OAuthRequest.CallbackUrl

  Removed OAuthService.CallbackUrl and replaced it with OAuthRequest.CallbackUrl
• Sep 29, 2009

  r139 (Removed SP-specific stuff from IToken (moved to IIssuedToken...) committed by bruceboughton   -   Removed SP-specific stuff from IToken (moved to IIssuedToken); Moved OAuthToken out of Consumer into Common; Changed OAuthRequest to use RequestTokenVerifier property properly; Updated examples to set RequestTokenVerifier properly

  Removed SP-specific stuff from IToken (moved to IIssuedToken); Moved OAuthToken out of Consumer into Common; Changed OAuthRequest to use RequestTokenVerifier property properly; Updated examples to set RequestTokenVerifier properly
• Sep 29, 2009

  r138 (Added license info to source file) committed by bruceboughton   -   Added license info to source file

  Added license info to source file
• Sep 29, 2009

  r137 (Fixed tests that used obsolete overloads that have been remo...) committed by bruceboughton   -   Fixed tests that used obsolete overloads that have been removed

  Fixed tests that used obsolete overloads that have been removed
• Sep 29, 2009

  r136 (Added changes to support Consumer Requests on the client sid...) committed by chris.s.adams   -   Added changes to support Consumer Requests on the client side - not fully tested.

  Added changes to support Consumer Requests on the client side - not fully tested.
• Sep 28, 2009

  r135 (Removed overloads marked as obsolete to make it easier to ma...) committed by bruceboughton   -   Removed overloads marked as obsolete to make it easier to maintain code

  Removed overloads marked as obsolete to make it easier to maintain code
• Sep 28, 2009

  SourceNotice Wiki page edited by bruceboughton   -   Revision r134 Updated source notice to note that the trunk is currently being disrupted.

  Revision r134 Updated source notice to note that the trunk is currently being disrupted.
• Sep 03, 2009

  issue 19 (Missing ServiceProviderContext.NonceProvider property) Status changed by chris.s.adams   -   Additional property added to ServiceProviderContext on trunk and class re-named

  Status: Fixed

  Additional property added to ServiceProviderContext on trunk and class re-named

  Status: Fixed
• Sep 03, 2009

  r133 (Added NonceProvider property to ServiceProviderContext and r...) committed by chris.s.adams   -   Added NonceProvider property to ServiceProviderContext and re-named MD5HashVerifierProvider to MD5HashVerificationProvider. See http://code.google.com/p/oauth-dot- net/issues/detail?id=19&colspec=ID%20Type%20Status%20Priority%20Owner%20Assembly%20Summary

  Added NonceProvider property to ServiceProviderContext and re-named MD5HashVerifierProvider to MD5HashVerificationProvider. See http://code.google.com/p/oauth-dot- net/issues/detail?id=19&colspec=ID%20Type%20Status%20Priority%20Owner%20Assembly%20Summary
• Sep 03, 2009

  issue 20 (OAuth.Net.Compants.HMacSha1SigningProvider.CheckSignature in...) Status changed by chris.s.adams   -   The issue was in the way the URL was being written out on the echo service provider web page. The + character wasn't a space but a + value. Because this wasn't being encoded when written out, when followed IIS was de-coding the + value into a space incorrectly. A change has been made to the trunk.

  Status: Fixed

  The issue was in the way the URL was being written out on the echo service provider web page. The + character wasn't a space but a + value. Because this wasn't being encoded when written out, when followed IIS was de-coding the + value into a space incorrectly. A change has been made to the trunk.

  Status: Fixed
• Sep 03, 2009

  r132 (Fixed echo provider to output correctly encoded URL.) committed by chris.s.adams   -   Fixed echo provider to output correctly encoded URL.

  Fixed echo provider to output correctly encoded URL.
• Aug 18, 2009

  issue 20 (OAuth.Net.Compants.HMacSha1SigningProvider.CheckSignature in...) reported by jaysen.marais   -   What steps will reproduce the problem? 1. Set a breakpoint on the return line of the OAuth.Net.Compants.HMacSha1SigningProvider.CheckSignature method 2. Hit the "Echo service provider" example and click the "Getting an access token" link. 3. If the signature contains a space, you will see the expectedSignature and actualSignature values differ only by the encoding of the space. (NOTE: if the signature doesn't contain a space, go back to step 2, refresh it to generate new oauth params and repeat)

  What steps will reproduce the problem? 1. Set a breakpoint on the return line of the OAuth.Net.Compants.HMacSha1SigningProvider.CheckSignature method 2. Hit the "Echo service provider" example and click the "Getting an access token" link. 3. If the signature contains a space, you will see the expectedSignature and actualSignature values differ only by the encoding of the space. (NOTE: if the signature doesn't contain a space, go back to step 2, refresh it to generate new oauth params and repeat)
• Aug 11, 2009

  issue 19 (Missing ServiceProviderContext.NonceProvider property) commented on by billyz...@yahoo.com   -   Also, a minor suggestion for consistency. Rename MD5HashVerifierProvider to MD5HashVerificationProvider. Or rename the interface to IVerifierProvider. I think the first one...

  Also, a minor suggestion for consistency. Rename MD5HashVerifierProvider to MD5HashVerificationProvider. Or rename the interface to IVerifierProvider. I think the first one...
• Aug 11, 2009

  issue 19 (Missing ServiceProviderContext.NonceProvider property) reported by billyz...@yahoo.com   -   Seems like this property should exist. For example, you have the following: * CallbackStore * ConsumerStore * RequestIdValidator * TokenGenerator * TokenStore * VerificationProvider * GetSigningProvider(string signatureMethod) But you are missing: * NonceProvider

  Seems like this property should exist. For example, you have the following: * CallbackStore * ConsumerStore * RequestIdValidator * TokenGenerator * TokenStore * VerificationProvider * GetSigningProvider(string signatureMethod) But you are missing: * NonceProvider
• Aug 05, 2009

  SourceNotice Wiki page edited by chris.s.adams   -   Revision r131 Edited wiki page through web user interface.

  Revision r131 Edited wiki page through web user interface.
• Aug 05, 2009

  OAuthNet-Release-0.7.1.0.zip (OAuth.net 0.7.0.0 Binaries) file uploaded by chris.s.adams   -  

  Labels: Featured Type-Binaries

  Labels: Featured Type-Binaries
• Aug 05, 2009

  OAuthNet-source-0.7.1.0.zip (OAuth.net 0.7.1.0 source code) file uploaded by chris.s.adams   -  

  Labels: Featured Type-Source

  Labels: Featured Type-Source
• Aug 05, 2009

  ChangeLog Wiki page edited by chris.s.adams   -   Revision r130 Edited wiki page through web user interface.

  Revision r130 Edited wiki page through web user interface.
• Aug 05, 2009

  ChangeLog Wiki page edited by chris.s.adams   -   Revision r129 Edited wiki page through web user interface.

  Revision r129 Edited wiki page through web user interface.
• Aug 05, 2009

  r128 (tag for 0.7.1.0 release) committed by chris.s.adams   -   tag for 0.7.1.0 release

  tag for 0.7.1.0 release
• Aug 05, 2009

  r127 (Modified to stop the workflow if no verifier is given when g...) committed by chris.s.adams   -   Modified to stop the workflow if no verifier is given when getting the AccessToken

  Modified to stop the workflow if no verifier is given when getting the AccessToken
• Aug 04, 2009

  issue 18 (NullReferenceException in OAuthRequestToken.cs) changed by chris.s.adams   -   Fix implemented into trunk.

  Status: Fixed

  Owner: chris.s.adams

  Fix implemented into trunk.

  Status: Fixed

  Owner: chris.s.adams
• Aug 04, 2009

  r126 (Changed Equals implementations and hashcodes to reflect guid...) committed by chris.s.adams   -   Changed Equals implementations and hashcodes to reflect guidelines better and avoid errors where parameters are null. See (http://code.google.com/p/oauth-dot-net/issues/detail?id=18)

  Changed Equals implementations and hashcodes to reflect guidelines better and avoid errors where parameters are null. See (http://code.google.com/p/oauth-dot-net/issues/detail?id=18)
• Aug 03, 2009

  issue 18 (NullReferenceException in OAuthRequestToken.cs) commented on by billyz...@yahoo.com   -   Ok, so a little more digging. Basically, checking the Keys property of a dictionary for a request token (e.g. what InMemoryCallbackStore does) does not currently work at all, even if the tokens are the exact same references! It has to do with all three of these methods below. Note that I had to comment out the bulk of these methods as a workaround to get ContainsKey working. So these definitely need further review/testing. public override bool Equals(object obj) { return Equals(obj as IRequestToken); /* commented out by Will if (obj == null) return false; if (obj is OAuthRequestToken) return false; return this.Equals((IRequestToken)obj); */ } public bool Equals(IRequestToken other) { if (other == null) return false; return base.Equals(other); /* commented out by Will return this.Token.Equals(other.Token) && this.Secret.Equals(other.Secret) && this.Status == other.Status && this.ConsumerKey.Equals(other.ConsumerKey) && this.AssociatedParameters.Equals(other.AssociatedParameters) && this.AuthenticatedUser.Equals(other.AuthenticatedUser) && Array.Equals(this.Roles, other.Roles); */ } public override int GetHashCode() { return base.GetHashCode(); /* commented out by Will return this.Token.GetHashCode() ^ this.Secret.GetHashCode() ^ this.Status.GetHashCode() ^ this.ConsumerKey.GetHashCode() ^ this.AssociatedParameters.GetHashCode() ^ this.AuthenticatedUser.GetHashCode() ^ this.Roles.GetHashCode(); */ }

  Ok, so a little more digging. Basically, checking the Keys property of a dictionary for a request token (e.g. what InMemoryCallbackStore does) does not currently work at all, even if the tokens are the exact same references! It has to do with all three of these methods below. Note that I had to comment out the bulk of these methods as a workaround to get ContainsKey working. So these definitely need further review/testing. public override bool Equals(object obj) { return Equals(obj as IRequestToken); /* commented out by Will if (obj == null) return false; if (obj is OAuthRequestToken) return false; return this.Equals((IRequestToken)obj); */ } public bool Equals(IRequestToken other) { if (other == null) return false; return base.Equals(other); /* commented out by Will return this.Token.Equals(other.Token) && this.Secret.Equals(other.Secret) && this.Status == other.Status && this.ConsumerKey.Equals(other.ConsumerKey) && this.AssociatedParameters.Equals(other.AssociatedParameters) && this.AuthenticatedUser.Equals(other.AuthenticatedUser) && Array.Equals(this.Roles, other.Roles); */ } public override int GetHashCode() { return base.GetHashCode(); /* commented out by Will return this.Token.GetHashCode() ^ this.Secret.GetHashCode() ^ this.Status.GetHashCode() ^ this.ConsumerKey.GetHashCode() ^ this.AssociatedParameters.GetHashCode() ^ this.AuthenticatedUser.GetHashCode() ^ this.Roles.GetHashCode(); */ }
• Aug 03, 2009

  issue 18 (NullReferenceException in OAuthRequestToken.cs) commented on by billyz...@yahoo.com   -   Another related issuein the Equals method: public override bool Equals(object obj) { if (obj == null) return false; if (obj is OAuthRequestToken) <-- is this correct?? this always returns false! return false; return this.Equals((IRequestToken)obj); }

  Another related issuein the Equals method: public override bool Equals(object obj) { if (obj == null) return false; if (obj is OAuthRequestToken) <-- is this correct?? this always returns false! return false; return this.Equals((IRequestToken)obj); }
• Aug 03, 2009

  issue 18 (NullReferenceException in OAuthRequestToken.cs) commented on by billyz...@yahoo.com   -   The Equals method has the same problem. These two methods get implicitly evaluated by the InMemoryCallbackStore which uses a dictionary for storage.

  The Equals method has the same problem. These two methods get implicitly evaluated by the InMemoryCallbackStore which uses a dictionary for storage.
• Aug 03, 2009

  issue 18 (NullReferenceException in OAuthRequestToken.cs) reported by billyz...@yahoo.com   -   This method in OAuthRequestToken.cs throws a NullReferenceException when the AuthenticatedUser property is null, which is a valid state for a request token. I am experiencing this error when the RequestTokenHandler process my callback URI. public override int GetHashCode() { return this.Token.GetHashCode() ^ this.Secret.GetHashCode() ^ this.Status.GetHashCode() ^ this.ConsumerKey.GetHashCode() ^ this.AssociatedParameters.GetHashCode() ^ this.AuthenticatedUser.GetHashCode() ^ this.Roles.GetHashCode(); }

  This method in OAuthRequestToken.cs throws a NullReferenceException when the AuthenticatedUser property is null, which is a valid state for a request token. I am experiencing this error when the RequestTokenHandler process my callback URI. public override int GetHashCode() { return this.Token.GetHashCode() ^ this.Secret.GetHashCode() ^ this.Status.GetHashCode() ^ this.ConsumerKey.GetHashCode() ^ this.AssociatedParameters.GetHashCode() ^ this.AuthenticatedUser.GetHashCode() ^ this.Roles.GetHashCode(); }
• Jul 24, 2009

  issue 16 (Encoding issue when parameters are provided by authorization...) Status changed by chris.s.adams   -   This issue has already been fixed in the trunk. No plans to fix on the 0.7.0.0 release branch at the moment - will issue a new relase soon.

  Status: Fixed

  This issue has already been fixed in the trunk. No plans to fix on the 0.7.0.0 release branch at the moment - will issue a new relase soon.

  Status: Fixed
• Jul 24, 2009

  r125 (Fixed Issue 17 http://code.google.com/p/oauth-dot-net/issues...) committed by chris.s.adams   -   Fixed Issue 17 http://code.google.com/p/oauth-dot-net/issues/detail?id=17.

  Fixed Issue 17 http://code.google.com/p/oauth-dot-net/issues/detail?id=17.
• Jul 24, 2009

  issue 17 (OAuthParameters constructor does not properly initialize its...) Status changed by chris.s.adams   -   Change implemented in trunk.

  Status: Fixed

  Change implemented in trunk.

  Status: Fixed
• Jul 23, 2009

  issue 16 (Encoding issue when parameters are provided by authorization...) commented on by billyz...@yahoo.com   -   This appears to be resolved in the main source trunk now. It's only an issue in the 0.7.0.0 release.

  This appears to be resolved in the main source trunk now. It's only an issue in the 0.7.0.0 release.
• Jul 23, 2009

  issue 17 (OAuthParameters constructor does not properly initialize its...) reported by billyz...@yahoo.com   -   I think there is a bug with the OAuthParameters constructor. It looks like you forgot to add the following line: this.Verifier = null; This causes a KeyNotFoundException if you try to check or access the OAuthParameters.Verifier property before it has been set somewhere else. I would expect the initial value to be null (like the other properties in the class), but instead I get the exception. For example, you can plainly see this issue when viewing a new instance of the OAuthParameters class in the debugger. -Will will@vertigo.com

  I think there is a bug with the OAuthParameters constructor. It looks like you forgot to add the following line: this.Verifier = null; This causes a KeyNotFoundException if you try to check or access the OAuthParameters.Verifier property before it has been set somewhere else. I would expect the initial value to be null (like the other properties in the class), but instead I get the exception. For example, you can plainly see this issue when viewing a new instance of the OAuthParameters class in the debugger. -Will will@vertigo.com
• Jul 23, 2009

  issue 16 (Encoding issue when parameters are provided by authorization...) reported by billyz...@yahoo.com   -   There seems to be a problem with the 0.7.0.0 release when using the authorization header to provide the OAuth parameters from a consumer application. Using the exact same code and providing the parameters via query string seems to work fine, so it appears to be a bug in the OAuth.Net.Components namespace, rather than something specific that I’m doing. So far, I’ve noticed the problem in two places, HmacSha1SigningProvider and MD5HashVerifierProvider. I get a [signature_invalid] error when checking the signature for a request or access token. Similarly, I get a [oauth_parameters_rejected, oauth_verifier] error if I implement a hack to workaround for the first error. The errors are thrown from the HmacSha1SigningProvider.CheckSignature and MD5HashVerifierProvider.IsValid methods. For example, here’s what I can see when debugging the latter method: verifier => HVlNt2MITzJsPSpkWFy8vw== hash => HVlNt2MITzJsPSpkWFy8vw%3D%3D When using the query string to provide the parameters, the hash correctly evaluates to "HVlNt2MITzJsPSpkWFy8vw==" thus allowing things to continue as expected. My guess is there is an issue with the OAuthParameters.ToHeaderFormat method and the Rfc3986 encoding – perhaps things are being double-encoded (i.e. both inside the ToHeaderFormat method and either before or after the method is called). -Will will@vertigo.com

  There seems to be a problem with the 0.7.0.0 release when using the authorization header to provide the OAuth parameters from a consumer application. Using the exact same code and providing the parameters via query string seems to work fine, so it appears to be a bug in the OAuth.Net.Components namespace, rather than something specific that I’m doing. So far, I’ve noticed the problem in two places, HmacSha1SigningProvider and MD5HashVerifierProvider. I get a [signature_invalid] error when checking the signature for a request or access token. Similarly, I get a [oauth_parameters_rejected, oauth_verifier] error if I implement a hack to workaround for the first error. The errors are thrown from the HmacSha1SigningProvider.CheckSignature and MD5HashVerifierProvider.IsValid methods. For example, here’s what I can see when debugging the latter method: verifier => HVlNt2MITzJsPSpkWFy8vw== hash => HVlNt2MITzJsPSpkWFy8vw%3D%3D When using the query string to provide the parameters, the hash correctly evaluates to "HVlNt2MITzJsPSpkWFy8vw==" thus allowing things to continue as expected. My guess is there is an issue with the OAuthParameters.ToHeaderFormat method and the Rfc3986 encoding – perhaps things are being double-encoded (i.e. both inside the ToHeaderFormat method and either before or after the method is called). -Will will@vertigo.com
• Jul 17, 2009

  issue 11 (Plaintext is broke) commented on by chris.s.adams   -   Hi Billy thanks for getting in contact. Can you provide some examples of the parameters that are causing mismatches with the Hmac signature.

  Hi Billy thanks for getting in contact. Can you provide some examples of the parameters that are causing mismatches with the Hmac signature.
• Jul 16, 2009

  issue 11 (Plaintext is broke) commented on by billyz...@yahoo.com   -   Is there not an identical issue with HmacSha1SigningProvider.cs? I am seeing frequent mismatches there as well and it still is using Rfc3986.Decode(signature).

  Is there not an identical issue with HmacSha1SigningProvider.cs? I am seeing frequent mismatches there as well and it still is using Rfc3986.Decode(signature).
• Jul 07, 2009

  r124 (Changed OAuthRequestContext to return the RequestToken from ...) committed by chris.s.adams   -   Changed OAuthRequestContext to return the RequestToken from the AccessToken if it has not been set previously.

  Changed OAuthRequestContext to return the RequestToken from the AccessToken if it has not been set previously.
• Jul 03, 2009

  r123 (Fixed passing of token to consumer callback store.) committed by chris.s.adams   -   Fixed passing of token to consumer callback store.

  Fixed passing of token to consumer callback store.
• Jul 03, 2009

  r122 (Fixed error where AuthHeader Params were not being Rfc3986 d...) committed by chris.s.adams   -   Fixed error where AuthHeader Params were not being Rfc3986 decoded.

  Fixed error where AuthHeader Params were not being Rfc3986 decoded.
• Jul 03, 2009

  r121 (Added clean to build script to ensure builds are signed.) committed by chris.s.adams   -   Added clean to build script to ensure builds are signed.

  Added clean to build script to ensure builds are signed.
• Jul 03, 2009

  r120 (Added IsOAuthRequest property to OAuthRequestContext to be a...) committed by chris.s.adams   -   Added IsOAuthRequest property to OAuthRequestContext to be able to determine in Service Provider if context is valid.

  Added IsOAuthRequest property to OAuthRequestContext to be able to determine in Service Provider if context is valid.
• Jul 02, 2009

  r119 (Changed to how the exception is reported to fix issue of it ...) committed by chris.s.adams   -   Changed to how the exception is reported to fix issue of it being cleared before written out.

  Changed to how the exception is reported to fix issue of it being cleared before written out.
• Jul 01, 2009

  r118 (Further changes to get the equality operators working.) committed by chris.s.adams   -   Further changes to get the equality operators working.

  Further changes to get the equality operators working.
• Jul 01, 2009

  r117 (Small change to equality and inequality operators to allow f...) committed by chris.s.adams   -   Small change to equality and inequality operators to allow for nulls.

  Small change to equality and inequality operators to allow for nulls.
• Jun 25, 2009

  r116 (added new OAuthRequestException and added handler to catch u...) committed by chris.s.adams   -   added new OAuthRequestException and added handler to catch uncaught ones to stream correctly to client.

  added new OAuthRequestException and added handler to catch uncaught ones to stream correctly to client.