Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does new PeriodBuilder().Build() throw? #88

Closed
GoogleCodeExporter opened this issue Mar 15, 2015 · 2 comments
Closed

Why does new PeriodBuilder().Build() throw? #88

GoogleCodeExporter opened this issue Mar 15, 2015 · 2 comments
Labels
bug

Comments

@GoogleCodeExporter
Copy link 

Currently, new PeriodBuilder().Build() will throw InvalidOperationException if 
there are no non-null properties.  It's not immediately clear why, since it 
would seem natural to return Period.Empty in that case.

Original issue reported on code.google.com by malcolm.rowe on 14 Jul 2012 at 9:15
@GoogleCodeExporter
Copy link
Author 

I strongly suspect that was written before Period.Empty existed, and should 
indeed be fixed to just return Period.Empty.

Original comment by jonathan.skeet on 14 Jul 2012 at 9:49

@GoogleCodeExporter
Copy link
Author 

The implementation was already correct - I've fixed the documentation in change 
4d54ce4732c5.

Original comment by jonathan.skeet on 14 Jul 2012 at 6:26

  • Changed state: Fixed

@malcolmr malcolmr added the bug label Mar 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@malcolmr @GoogleCodeExporter