Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateTimeZone shouldn't have reader/writer parts in the abstract API. #77

Closed
GoogleCodeExporter opened this issue Mar 15, 2015 · 4 comments
Closed

DateTimeZone shouldn't have reader/writer parts in the abstract API. #77

GoogleCodeExporter opened this issue Mar 15, 2015 · 4 comments
Labels
bug
Milestone
1.0.0

Comments

@GoogleCodeExporter
Copy link 

Third parties should be able to implement their own time zone providers and 
time zones. Currently the read/write part prohibits this, as it uses internal 
types.

Given that the read/write format of time zones is really 
implementation-specific, it shouldn't be part of the abstract API. The current 
format is only used for TZDB, which should be made explicit.

Original issue reported on code.google.com by jonathan.skeet on 23 Jun 2012 at 7:00
@GoogleCodeExporter
Copy link
Author 

Fixed in changeset 43fe2086cdb9.

Note that there's still at least one internal virtual method, but that's just 
an optimization (which itself uses an internal type) - hopefully this won't be 
a problem.

Original comment by jonathan.skeet on 23 Jun 2012 at 7:54

@GoogleCodeExporter
Copy link
Author 

I'd still like to separate the IO further, but it's not in the abstract API any 
more.

Original comment by jonathan.skeet on 25 Jun 2012 at 7:09

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Original comment by malcolm.rowe on 30 Jul 2012 at 7:26

  • Added labels: Milestone-1.0
  • Removed labels: V1-Blocker

@GoogleCodeExporter
Copy link
Author

Original comment by malcolm.rowe on 10 Nov 2012 at 10:20

  • Added labels: Milestone-1.0.0
  • Removed labels: Milestone-1.0

@malcolmr malcolmr added the bug label Mar 15, 2015
@malcolmr malcolmr modified the milestone: 1.0.0 Mar 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@malcolmr @GoogleCodeExporter