Skip to content
This repository has been archived by the owner on Nov 18, 2017. It is now read-only.

Don't use binary annotation for thumbnails #162

Closed
GoogleCodeExporter opened this issue May 6, 2015 · 6 comments
Closed

Don't use binary annotation for thumbnails #162

GoogleCodeExporter opened this issue May 6, 2015 · 6 comments

Comments

@GoogleCodeExporter
Copy link

I sent this over mail, but just in case it was not received:

Hi Mihailo,

My name is Asaf Romano. I'm a member of the Firefox team at Mozilla Corporation.

As part of an ongoing effort to switch the Places Bookmarks & History system to 
asynchronous APIs, we're slowly deprecating the annotations API.

The first step in this direction is the removal of "binary annotations". This 
change is about to land on mozilla-central repository in the next couple of 
days affecting nightly build initially. Firefox Beta will see this change in 
nine weeks, and the official Firefox release will see this change in about 
fifteen weeks.

I've learned that your addon, New Tab JumpStart, utilizes this API for storing 
thumbnails for its new-tab-page implementation, and therefore wanted to provide 
you with few alternative APIs.

First in order is PageThumbs.jsm, a Javascript Module which provides the very 
same functionality. I cannot guarantee you this module won't change over time 
because it is quite new. However, it uses long-standing APIs, so another option 
is to clone it in your addon (using a different storage directory in the 
profile).

Finally, should you still wish to use the annotations API, a possible solution 
is to store the image files in a sub-directory under the profile directory, and 
then point to these files in regular string annotations. I don't recommend this 
approach because, as I noted above, the annotations api is about to be 
deprecated and very likely removed at some point.

Should you have any question with regard to implementing any of these options, 
please let me know.

Regards,
Asaf 

Original issue reported on code.google.com by asaf.moz...@gmail.com on 22 Jul 2013 at 7:05

@GoogleCodeExporter
Copy link
Author

Original comment by mlalevic@gmail.com on 22 Jul 2013 at 10:09

  • Changed state: Accepted
  • Added labels: Priority-Critical
  • Removed labels: Priority-Medium

@GoogleCodeExporter
Copy link
Author

Thanks :) Please email me to mano [at] mozilla [dot] com if anything comes up. 
I don't check this email often.

Original comment by asaf.moz...@gmail.com on 23 Jul 2013 at 4:31

@GoogleCodeExporter
Copy link
Author

Update: the API is now removed on Mozilla trunk (affecting nightly builds).

Original comment by asaf.moz...@gmail.com on 6 Aug 2013 at 5:51

@GoogleCodeExporter
Copy link
Author

Issue 164 has been merged into this issue.

Original comment by mlalevic@gmail.com on 4 Nov 2013 at 10:40

@GoogleCodeExporter
Copy link
Author

Fixed. Version 0.5a5.5.4 awaiting review. Can be accessed from version history 
page:
https://addons.mozilla.org/en-US/firefox/addon/new-tab-jumpstart/versions/
or directly:
https://addons.mozilla.org/firefox/downloads/file/233032/new_tab_jumpstart-0.5a5
.5.4-fx.xpi?src=version-history

Original comment by mlalevic@gmail.com on 4 Nov 2013 at 10:43

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Issue 164 has been merged into this issue.

Original comment by mlalevic@gmail.com on 4 Nov 2013 at 10:43

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant