My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 316: Narro nukes the access keys on export
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  alex...@gmail.com
Closed:  Jul 2012


Sign in to add a comment
 
Reported by fil...@gmail.com, Jul 1, 2012
What steps will reproduce the problem?
1. Check out the latest exported Serbian L10n at http://a.maimult.ro/lmo/includes/narro/plugins/NarroExportArchive.class.php?p=34&pn=Firefox%20Beta&l=sr
2. See the attached files -- the diff from the previous version in after-export.part, and the list of access keys nuked at access-keys-removed.patch.part
3.

What is the expected output? What do you see instead?
Narro shouldn't ever nuke access keys if the translations thereof are present.


What version of the product are you using?
Whatever is now current on the narro website.

after-export.patch
704 KB   View   Download
access-keys-removed.patch.part
70.3 KB   View   Download
Jul 10, 2012
Project Member #1 alex...@gmail.com
What do you mean by nuke ? Is there nothing exported or is the English access key exported ?
Jul 18, 2012
Project Member #2 alex...@gmail.com
Any news on this ? I need a specific example of one file and one access key refered by its key in the file to be able to research this.
Jul 18, 2012
#3 fil...@gmail.com
Sorry, I've been busy elsewhere.  Will make an example once able.
Jul 20, 2012
#4 l10n....@gmail.com
http://mxr.mozilla.org/l10n-mozilla-aurora/source/ms/dom/chrome/layout/htmlparser.properties#50 is likely one of the examples of busted '&' handling.

As are the '&' in dom/chrome/layout/htmlparser.properties browser/chrome/browser/quitDialog.properties browser/chrome/browser-region/region.properties browser/installer/custom.properties browser/installer/mui.properties browser/installer/override.properties toolkit/chrome/global/commonDialogs.properties toolkit/chrome/passwordmgr/passwordmgr.properties toolkit/chrome/search/search.properties

This leads to horribly broken localizations. Beyond broken accesskeys, this breaks installer variables, I've come across various places that talk about $Brand&ShortName.
Jul 24, 2012
Project Member #5 alex...@gmail.com
There where three problems in total, all fixed in other issues. Can you please retest?
Status: Fixed
Sign in to add a comment

Powered by Google Project Hosting