Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narro export extranous files for Search Engines #297

Open
GoogleCodeExporter opened this issue Mar 13, 2015 · 1 comment
Open

Narro export extranous files for Search Engines #297

GoogleCodeExporter opened this issue Mar 13, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link
Collaborator

Comments from code review. 
"Narro seems to be adding files for search engines in list.txt if there aren't 
any .xml files with the same name in /browser/searchplugins/ directory. Anthow, 
that's a wrong way to do stuff, as we only need files for the search engines we 
don't already have in en-US. So, what you want to do is, create search plugin 
in /browser/searchplugins/ named wikipedia-km.xml and change the `wikipedia` to 
`wikipedia-km` in list.txt file"

Also, I don't understand wht wikipedia-hy.xml is here, at all.

Based on the comments from here:
https://bugzilla.mozilla.org/show_bug.cgi?id=709140#c26

Original issue reported on code.google.com by hitmana...@gmail.com on 3 Feb 2012 at 9:47

@GoogleCodeExporter
Copy link
Collaborator Author

Each locale can set up which files it should not export. Narro doesn't handle 
list.txt, so that needs to be done manually as instructed in the localization 
guidelines. But I do need list.txt to build an xpi.

If an extraneous file is in the export, do another export and check to clean 
the output before proceeding.

Not sure yet what the ideal thing to do is, but I'd suspect with Mozilla we 
need some other things than translations, like search engine management, window 
sizes.

I'm open to ideas.


Original comment by alex...@gmail.com on 9 Feb 2012 at 5:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant