Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_mozc.py --noqt option doesn't work on latest revision on Mac (again, r58) #90

Closed
GoogleCodeExporter opened this issue Apr 22, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Run python build_mozc.py gyp --noqt option
2. Build tool, then build mozc then it will get failed.

What is the expected output? What do you see instead?
We should be able to build Mozc witout qt on Mac OS X.

What version of the product are you using? On what operating system?
$ uname -rsv
Darwin 10.8.0 Darwin Kernel Version 10.8.0: Tue Jun  7 16:33:36 PDT 2011; 
root:xnu-1504.15.3~1/RELEASE_I386

$ svn info|grep Revision
Revision: 58

Please provide any additional information below.
The last commit which remove qt_common.gpyi and rewrite qt_libraries.gypi 
doesn't work with --noqt option due to missing qt_dir_env variant which is 
defined in qt_target_defaults.gypi so we might need to include this file even 
if we have --noqt option.
I've attached a patch.

Also, I guess you remove --noqt options from build_mozc.py build command so 
need to update wiki document which is still saying adding --noqt to that.

Or, are you going to remove --noqt options completely?

Original issue reported on code.google.com by niw%niw.at@gtempaccount.com on 21 Jul 2011 at 7:17

Attachments:

@GoogleCodeExporter
Copy link
Author

> Also, I guess you remove --noqt options from build_mozc.py build command so 
need to update wiki document which is still saying adding --noqt to that.

This is the right story.  I've updated the wiki page.

Original comment by yukawa@google.com on 22 Jul 2011 at 12:48

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Also, $(qt_dir_env) issue has already been fixed in the internal repository.
Unfortunately, r58 doesn't contain this fix because it was not cherry-picked to 
the ver 1.1 release branch. 

I expect the next (1.2.xxx) release cycle will fix this issue completely.

Original comment by yukawa@google.com on 22 Jul 2011 at 1:09

@GoogleCodeExporter
Copy link
Author

r61 contains this fix.
Please verify if it works for you.

Thank you.

Original comment by yukawa@google.com on 17 Aug 2011 at 3:14

@GoogleCodeExporter
Copy link
Author

Original comment by yukawa@google.com on 1 Apr 2012 at 2:56

  • Added labels: OpSys-OSX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant