Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export then Import a MSE Model throws FMSyntaxError #951

Closed
seandenigris opened this issue Aug 3, 2015 · 5 comments
Closed

Export then Import a MSE Model throws FMSyntaxError #951

seandenigris opened this issue Aug 3, 2015 · 5 comments
Labels
FAMIX

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 951

Hi,

I wanted to export and import a MSE file of a Moose Model.
The export works perfectly but the import which throws an FMSyntaxError.

You can reproduce from the Moose Panel by creating a Model from Smalltalk, 
export it (Import/export / Export to MSE), and import it.

The pragma in FAMIXMethod>>clientClasses :
<MSEProperty: 'Client classes' type: #FAMIXType> <multivalued>
seems to be the problem. Indeed 'Client Classes' contains a space character which is
not recognize by the MSE parser.

I resolved by deleting the space.

Reported by v.blondeau92 on 2013-07-05 13:54:05
@seandenigris
Copy link
Contributor Author 

So the new pragma is
<MSEProperty: #clientClasses type: #FAMIXType> <multivalued>

Reported by v.blondeau92 on 2013-07-05 14:28:29

@seandenigris
Copy link
Contributor Author 

Good catch. Could you create a test for this?

Also, where did you commit the fix?

Reported by tudor@tudorgirba.com on 2013-07-07 15:58:41

  • Labels added: Component-Famix, Milestone-4.8

@seandenigris
Copy link
Contributor Author 

I saw you fix it, so I didn't integrate it in the slice.

I made a test to test the export and the import of a same model through a MSE file.
The test is in the following repo :
MCHttpRepository
    location: 'http://smalltalkhub.com/mc/VincentBlondeau/MooseStore/main'
    user: ''
    password: ''

The package to load is : SLICE-Issue-951-Export-then-Import-a-MSE-Model-throws-FMSyntaxError

However the test fails.... The method 'clientClasses:' is not implemented. I don't
know how to do it.

Reported by v.blondeau92 on 2013-07-08 11:05:55

@seandenigris
Copy link
Contributor Author 

clientClasses
    "returns a set of all the classes that depend on the receiver"
    <MSEProperty: #clientClasses type: #FAMIXType> <multivalued> <derived>

Reported by tudor@tudorgirba.com on 2013-07-14 12:19:08

  • Status changed: Fixed

@seandenigris
Copy link
Contributor Author 

The clientClasses is a derived property and should not be saved in the MSE in the first
place.

Reported by tudor@tudorgirba.com on 2013-07-14 12:19:46

@jecisc jecisc added the FAMIX label Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FAMIX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seandenigris @jecisc