Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EyeSee red-square-of-death from ESValueLabelDecorator>>chooseNonOverlappingValues #923

Closed
seandenigris opened this issue Aug 3, 2015 · 3 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 923

ESValueLabelDecorator>>chooseNonOverlappingValues has the line... 
    chosenValues add: (self values minValue: [:each | each value]).

but minValue: injects (Float infinity) so that if  'self values' is empty then (Float
infinity) is added to choseValues, which later are #rounded causing an error in the
Morph drawing and subsequent RSOD for the EyeSee morph.

I am not sure if I've done something wrong that causes 'self values' to be empty, but
in any case, this should not kill the Morph.

Just for further information, here is the triggering code...
    browser transmit from: #navigationtree; to: #attributes; andShow: 
    [   :a | 
                a eyesee 
            title: 'Optimize' ;
            diagram: 
            [   :renderer :input | 
                renderer scatterplot 
                    diagramTitle: '@', input absorbedLoad asString , 'kW' ;
                    x: #ratedOutput ;
                    y: [ :m | m powerLossForAbsorbedLoad: input absorbedLoad  ]  ; 
                    valueAxis ;
                    addXDecorator: ESValueLabelDecorator new ;
                    models: (LEKCatalogMotor catalog values sort: [ :m1 :m2 | m1 ratedOutput < m2
ratedOutput ]).
].

where if in a Workspace I do...
    models:= (LEKCatalogMotor catalog values sort: [ :m1 :m2 | m1 ratedOutput < m2
ratedOutput ])'.
    models collect: [ :m | m ratedOutput -> m powerLossForAbsorbedLoad: 24 ] explore

...then all the data looks okay. 



Reported by benjamin.t.coman on 2013-03-30 16:42:41

@seandenigris
Copy link
Contributor Author

Here is an example to isolate the problem from my own code...

The following works as expected...
|diag|
diag := ESDiagramRenderer new.
(diag scatterplot)
    y: [ :x | x squared ];
    x: #value;
    valueAxis;
    models: {1. 2. 3. 4. 5}.
diag open

However replace with the line...
    y: [ :x | x squared negated ];

and you get the error

Reported by benjamin.t.coman on 2013-03-31 13:30:00

@seandenigris
Copy link
Contributor Author

I think this won't get fixed if we focus on Graph-ET

Reported by tudor@tudorgirba.com on 2013-11-17 10:20:00

  • Status changed: WontFix

@seandenigris
Copy link
Contributor Author

fair enough

Reported by benjamin.t.coman on 2013-11-17 11:50:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant