Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glamour presentations should update their own actions when receiving GLMPresentationUpdated #912

Closed
seandenigris opened this issue Aug 3, 2015 · 4 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 912

Right now when a presentation receives GLMPresentationUpdated it does not update its
own actions.
For example bellow is some code to see this behaviour.
When the action from the composite presentation is triggered it updates the action
from the contained presentations but not its action.

Also if there is just one presentation in the composite then, due to how a composite
with one presentation is implemented, it won't update any action.

|browser|

browser := GLMTabulator new.
browser row: #aRow.

browser transmit to: #aRow; andShow: [ :composite |
    composite
        title: 'Composite';
        updateOn: Announcement from: [ browser announcer ]; 
        dynamicActions: [ :list || actions |
            actions := OrderedCollection new.
            actions add: 
                ((GLMGenericAction new) 
                    action: [ :presentation :model | browser announce: Announcement]; 
                    icon: GLMUIThemeExtraIcons glamorousAdd;
                    title: DateAndTime now asString;
                    yourself).
                actions
                ].

    composite list
        title: 'List 1';
        updateOn: Announcement from: [ browser announcer ]; 
        dynamicActions: [ :list || actions |
            actions := OrderedCollection new.
            actions add: 
                ((GLMGenericAction new) 
                    action: [ :presentation :model | browser announce: Announcement]; 
                    icon: GLMUIThemeExtraIcons glamorousAdd;
                    title: DateAndTime now asString;
                    yourself).
                actions
                ].
    composite list
        title: 'List 2'].

browser openOn: (1 to: 10)

Reported by chisvasileandrei on 2013-02-07 15:45:30

@seandenigris
Copy link
Contributor Author

Reported by tudor@tudorgirba.com on 2013-06-23 19:34:54

  • Labels added: Component-Glamour, Milestone-4.8

@seandenigris
Copy link
Contributor Author

Is this working already?

Reported by tudor@tudorgirba.com on 2013-06-24 19:04:21

@seandenigris
Copy link
Contributor Author

Not yeat. I haven't figured out a clean solution for the moment.

Reported by chisvasileandrei on 2013-06-25 12:54:07

@seandenigris
Copy link
Contributor Author

This will likely not make it for 4.8.

Reported by tudor@tudorgirba.com on 2013-06-30 20:27:36

  • Labels removed: Milestone-4.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants