Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAMIXType>>classScope should not return nil #906

Closed
seandenigris opened this issue Aug 3, 2015 · 6 comments
Closed

FAMIXType>>classScope should not return nil #906

seandenigris opened this issue Aug 3, 2015 · 6 comments
Labels
FAMIX

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 906

Right now, the classScope in FAMIXType returns nil, which is a problem.

FAMIXType>>classScope
   "all types are not classes. Redefined in FamixClass"
   ^ nil

Either we make it return self, or we introduce typeScope.

Reported by tudor@tudorgirba.com on 2013-01-28 16:38:50
@seandenigris
Copy link
Contributor Author 

This is linked to  issue 814

What is the use case requiring typeScope?
Can one of the solutions proposed in issue 814 solve it?

Reported by anquetil.nicolas on 2013-01-31 21:11:54

@seandenigris
Copy link
Contributor Author 

FAMIXAnnotationType new classScope ==> nil
and because of this
FAMIXAnnotationType new namespaceScope ==> nil

This should not happen. We could make classScope return self (but the name is not so
fortunate because it FAMIXAnnotationType is not quite a class), or we can introduce
typeScope.

Reported by tudor@tudorgirba.com on 2013-02-02 22:30:15

@seandenigris
Copy link
Contributor Author 

Nope

FAMIXType namespacescope does not depend on ClassScope but only on the presence of
a container

FAMIXAnnotationType new container: FAMIXNamespace new ; namespaceScope

Anyway do we replace classScope by typeScope ?
(and atClassScope by atTypeScope)

Reported by anquetil.nicolas on 2013-02-03 10:50:28

  • Status changed: Started

@seandenigris
Copy link
Contributor Author 

Yes, let's replace classScope with typeScope. Any taker?

Reported by tudor@tudorgirba.com on 2013-05-31 05:44:21

@seandenigris
Copy link
Contributor Author 

renamed classScope to typeScope (and deprecated classScope)
renamed atClassScope to atTypeScope (and deprecated atClassScope)

Reported by tudor@tudorgirba.com on 2013-06-30 20:54:58

@seandenigris
Copy link
Contributor Author 

Also, now typeScope returns self for all types.

Reported by tudor@tudorgirba.com on 2013-07-01 05:14:54

  • Status changed: Fixed
  • Labels added: Milestone-4.8

@jecisc jecisc added the FAMIX label Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FAMIX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seandenigris @jecisc