Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing browser instance variable #881

Closed
seandenigris opened this issue Aug 3, 2015 · 4 comments
Closed

Missing browser instance variable #881

seandenigris opened this issue Aug 3, 2015 · 4 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 881

PPParserBrowser and PPAllParserBrowser are missing browser instance variable, since
the supperclass was changed from BrowserTemplate to CompsoitePresentation (PetitGui.107).

I presume, this is minor issue, but I have no idea why it was changed from Template
to CompositePresentation.

Reported by kurs.jan on 2012-11-30 13:53:09
@seandenigris
Copy link
Contributor Author 

Hope, the JanKurs.108 is OK as a fix.

Reported by kurs.jan on 2012-11-30 14:05:47

  • Status changed: Started

@seandenigris
Copy link
Contributor Author

Reported by kurs.jan on 2012-11-30 14:07:27

  • Status changed: Fixed

@seandenigris
Copy link
Contributor Author 

The problem was actually that the buildBrowser methods should be deleted because we
have compose instead (now that the browsers inherit from GLMCompositePresentation)

Reported by tudor@tudorgirba.com on 2012-11-30 16:40:08

@seandenigris
Copy link
Contributor Author

Reported by tudor@tudorgirba.com on 2013-03-03 13:06:07

  • Labels added: Milestone-4.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seandenigris