Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving VerveineJ stub invocations/methods #880

Closed
seandenigris opened this issue Aug 3, 2015 · 14 comments
Closed

Improving VerveineJ stub invocations/methods #880

seandenigris opened this issue Aug 3, 2015 · 14 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 880

When creating models without classpath, invocations/methods (where the biding are not
found) are created in the format:

anInvocation(???)

This is the case even if the real invocation in source code contains parameters such
as:

anInvocation(a, b)

It would be good maintain the information with respect to the number of parameters
in such invocation/method, and then export the #signature with something like:

anInvocation(?, ?)

Like that we can at least count the number of parameters.

Reported by andrehoraa on 2012-11-29 14:51:17

@seandenigris
Copy link
Contributor Author

Actually, this observation applies not just for invocations to stub methods, but for
any kind of invocations.

Let's take the invocation example:
aMethod(a, b()), where a and b() are of types A and B, respectively

Right now, even if we know the method, we get as a signature aMethod(A, B). This information
is essentially not useful, because we already have the definition of the method and
its parameters.

So, even in this case, we would still benefit from having aMethod(a, b()) as a signature
because it provides extra information.

Reported by tudor@tudorgirba.com on 2012-11-30 06:59:09

@seandenigris
Copy link
Contributor Author

Fixed first issue (andrehoraa). Please check this is what was needed.

For 2nd comment (tudor) I am not sure I understand.
The signature of the method is its name and the type of its parameters, it is independant
of the different calls one can make.
Please clarify

Reported by anquetil.nicolas on 2012-11-30 14:47:46

  • Status changed: Fixed

@seandenigris
Copy link
Contributor Author

We are talking about the signature of an invocation, not of a method. This should be
the text corresponding to the call, and not a duplicate of the signature of the method.

Reported by tudor@tudorgirba.com on 2012-11-30 16:28:32

@seandenigris
Copy link
Contributor Author

OK, never noticed that invocations had signature  :-)

Will have to look at it

Reported by anquetil.nicolas on 2012-11-30 17:59:03

  • Status changed: Accepted

@seandenigris
Copy link
Contributor Author

Nicolas, my issue is fixed. Thanks :)


I understood what Doru is saying. But consider the invocation #setElements in a source
code:

setElements(Model.getModelManagementHelper()
                    .getAllModelElementsOfKindWithModel(model,
                            Model.getMetaTypes().getTagDefinition()));

Do we want to see in the MSE exactly the signature above or the code below?

setElements(?)

I believe the second one is also relevant.
Maybe we can have both? Something like #signature and #realSignature?




Reported by andrehoraa on 2012-11-30 18:19:10

@seandenigris
Copy link
Contributor Author

@Andre: I do not understand. If you get the signature of the stub method, why is it
important to have setElements(?)?

Reported by tudor@tudorgirba.com on 2012-11-30 21:21:29

@seandenigris
Copy link
Contributor Author

Just because it is simpler to read and more important because when it is not stub you
can see the type of the parameters ex: setElements(String)

Reported by andrehoraa on 2012-12-03 00:31:13

@seandenigris
Copy link
Contributor Author

I do not understand. Why do you need to read the signature of an invocation? And why
is it not enough to have the "setElements(String)" signature in the called method?

Reported by tudor@tudorgirba.com on 2012-12-07 22:23:27

@seandenigris
Copy link
Contributor Author

As I said, just because I think it is simpler, clearer, and you easily see the number
of parameters and the types (when not stub) from such invocation. But yes, you can
also check it from the #candidates methods if you have them.
And yes, see the full invocation like you said is nice too as it provides extra information
(but not easily the number of parameters and the types :)

Reported by andrehoraa on 2012-12-10 00:25:21

@seandenigris
Copy link
Contributor Author

Reported by tudor@tudorgirba.com on 2013-01-27 08:21:59

  • Labels added: Milestone-4.8
  • Labels removed: Milestone-4.7

@seandenigris
Copy link
Contributor Author

Reported by anquetil.nicolas on 2013-02-03 13:57:03

  • Status changed: Fixed

@seandenigris
Copy link
Contributor Author

How did you fix this?

Reported by tudor@tudorgirba.com on 2013-02-03 15:30:07

@seandenigris
Copy link
Contributor Author

As you asked in email #1

Reported by anquetil.nicolas on 2013-02-03 17:52:17

@seandenigris
Copy link
Contributor Author

Great!

Reported by tudor@tudorgirba.com on 2013-02-03 19:36:07

  • Labels added: Milestone-4.7
  • Labels removed: Milestone-4.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant