Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROCircle strange MNU #extent: #857

Closed
seandenigris opened this issue Aug 3, 2015 · 9 comments
Closed

ROCircle strange MNU #extent: #857

seandenigris opened this issue Aug 3, 2015 · 9 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 857

With ConfigurationOfRoassal.667 just loaded, my project application popped up a 'MNU:
receiver of "extent:" is nil, but as you can see in the attached screen snapshot, which
has the default debugger highlighting showing the current executiong, the receiver
is the ivar 'next' which is actually _not_ nil, but an instance of RONullShape.  Strange...

As a test case, executing the following in Rossal Easel caused the same MNU.
=========
rawView add: (ROElement on: 1) + ROCircle.
=========

Fixed it  with: Compiler recompileAll. This actually has happened to me a few times
in past couple of weeks.

(Note actually the example code gives a really tiny circle and #spriteOn: would have
been better than #on:)

Reported by benjamin.t.coman on 2012-10-20 14:28:35

- _Attachment: ROCircle-MNU-extent.png
![ROCircle-MNU-extent.png](https://storage.googleapis.com/google-code-attachments/moose-technology/issue-857/comment-0/ROCircle-MNU-extent.png)_
@seandenigris
Copy link
Contributor Author 

Also, something has happened to ROCircle that it is no longer constrained to be a circle.
 The aim of this was so when the text of an element got wider or higher, the other
dimension followed to maintain the circle within which the text was centred.
This was working in Roassal-AlexandreBergel.352, which you can see with the green ConnectivityNode
circles in my project application that I previously uploaded the image to [1].  If
you update that image to Roassal.363 (ConfigurationOfRoassal.667)
then the circles are flat.

[1] http://files.openinworld.com/ENG8002/20121020-moose47-LEETRICAL.zip

Reported by benjamin.t.coman on 2012-10-20 14:39:41

@seandenigris
Copy link
Contributor Author 

I have found two bugs in the way ROCircle is implemented. Maybe you have bumped into
these...

Reported by alexandre.bergel on 2012-10-21 00:43:15

@seandenigris
Copy link
Contributor Author 

Is this still an issue?

Reported by tudor@tudorgirba.com on 2013-02-02 20:40:25

  • Labels added: Component-Roassal

@seandenigris
Copy link
Contributor Author 

Ben, do you still experience that problem?

Reported by alexandre.bergel on 2013-03-06 19:26:00

  • Status changed: Started

@seandenigris
Copy link
Contributor Author 

A can't reproduce the MNU.  I don't think that was a Roassal problem.  Seemed like something
unstable in the system but I couldn't pin it down.  As per the title fo this ticket,
it should be closed.

However I still note that the following in Easel does not produce a circle :P
x := (ROElement on: 1) + ROCircle.
rawView add: x.
x height: 100; width: 200.

Reported by benjamin.t.coman on 2013-03-07 12:24:07

@seandenigris
Copy link
Contributor Author 

(Sorry) to be explicit, "Circles" should be constrained to remain a circle when either
dimension is changed.

Reported by benjamin.t.coman on 2013-03-07 12:25:13

@seandenigris
Copy link
Contributor Author 

ROCircle was renamed to ROEllipse.

Reported by vhanella on 2013-03-13 02:30:07

@seandenigris
Copy link
Contributor Author 

Cool, thanks.

Reported by benjamin.t.coman on 2013-03-13 03:49:08

@seandenigris
Copy link
Contributor Author

Reported by tudor@tudorgirba.com on 2013-07-07 18:03:09

  • Status changed: Fixed
  • Labels added: Milestone-4.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seandenigris