Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RORubberband with target highlighting #852

Closed
seandenigris opened this issue Aug 3, 2015 · 7 comments
Closed

RORubberband with target highlighting #852

seandenigris opened this issue Aug 3, 2015 · 7 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 852

I have added highlighting of target elements to RORubberband - changeset attached. Note
changeset is against Roassal-AlexandreBergel.343.mcz since .344 breaks something.

Note2, I renamed RORubberbanding to RORubberband.  I had originally been tossing up
between the two, and under further consideration I think the latter is more appropriate.
 The former will need to be manually removed.

Reported by benjamin.t.coman on 2012-10-14 15:51:14

- _Attachment: [RubberBand2.3.cs](https://storage.googleapis.com/google-code-attachments/moose-technology/issue-852/comment-0/RubberBand2.3.cs)_
@seandenigris
Copy link
Contributor Author 

It appears that the problem with .344 might just be something at my end.  Downloading
moose4.7 just now that includes .344 has no problem.

Reported by benjamin.t.coman on 2012-10-14 18:46:11

@seandenigris
Copy link
Contributor Author 

Tracked the problem down - due to version .344 adding the ivar 'offset' to 
ROShorterDistanceAttachPoint and also...
----
ROShorterDistanceAttachPoint>>initialize
    super initialize.
    offset := 0.
----

but ROAbstractLine>>initialize uses 'ROShorterDistanceAttachPoint instance' to 
get a cached object...
----
ROShorterDistanceAttachPoint >>instance
    instance ifNil: [ instance := self new ].
    ^ instance
----

so the offset ivar of the cached object was 'nil' rather than the expected '0', 
and fixed with...
ROShorterDistanceAttachPoint resetInstance

Reported by benjamin.t.coman on 2012-10-15 13:37:37

@seandenigris
Copy link
Contributor Author 

I have updated this to Roassal-BenComan.348 based off latest Roassal-AlexandreBergel.345.
 It is attached as a mcz since I was having trouble using Change Sorter properly.

Renamed RORubberBanding to RORubberBand.
Added target highlighting to RORubberBand.
Added RORemoveEdge.

Reported by benjamin.t.coman on 2012-10-15 13:42:37

- _Attachment: [Roassal-BenComan.348.mcz](https://storage.googleapis.com/google-code-attachments/moose-technology/issue-852/comment-3/Roassal-BenComan.348.mcz)_

@seandenigris
Copy link
Contributor Author 

An alternative implementation that exposes more end-user control of actions applied
to items moving into and out of the target selection (see attached .349). 

Created ROSelection. Modified RORubberBand and ROExample>>rubberBandOn: to use this.
 The side-effect is slightly streamlined  RORubberBand>>initializeElement: and reduced
RORubberBand ivars.

Reported by benjamin.t.coman on 2012-10-15 14:35:59

- _Attachment: [Roassal-BenComan.349.mcz](https://storage.googleapis.com/google-code-attachments/moose-technology/issue-852/comment-4/Roassal-BenComan.349.mcz)_

@seandenigris
Copy link
Contributor Author 

Some cleanup of RORubberBand that I missed.

Reported by benjamin.t.coman on 2012-10-15 15:23:59

- _Attachment: [Roassal-BenComan.350.mcz](https://storage.googleapis.com/google-code-attachments/moose-technology/issue-852/comment-6/Roassal-BenComan.350.mcz)_

@seandenigris
Copy link
Contributor Author 

In Roassal 1.166. Thanks Ben!

Reported by alexandre.bergel on 2012-10-15 16:18:30

  • Status changed: Fixed
  • Labels added: Component-Roassal

@seandenigris
Copy link
Contributor Author

Reported by tudor@tudorgirba.com on 2013-03-03 13:04:50

  • Labels added: Milestone-4.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seandenigris