Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mondrian should store edges in the most specific parent of the from/to nodes #798

Closed
seandenigris opened this issue Aug 3, 2015 · 4 comments
Closed

Mondrian should store edges in the most specific parent of the from/to nodes #798

seandenigris opened this issue Aug 3, 2015 · 4 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 798

The edges should be stored in the most specific parent of the from and to nodes, and
not in the parent of the node in which they are defined.

This is because the layout takes this information into account. For example, the below
layout does not show a tree inside node 1.

view := MOViewRenderer new.
view node: 1 forIt: [
    view shape label.
    view nodes: (10 to: 11).
    view treeLayout.
    ].
view edgesFromAssociations: {10 -> 11}.
view open.

Reported by tudor.girba on 2012-05-26 20:30:51
@seandenigris
Copy link
Contributor Author 

Name: Mondrian-Core-TudorGirba.81
Author: TudorGirba
Time: 26 May 2012, 11:28:20.438 pm
UUID: bbdf3344-e0af-4053-af61-9b4490d43587
Ancestors: Mondrian-Core-BenComan.80

fixed

Issue 798:  Mondrian should store edges in the most specific parent of the from/to nodes

The problem was with:
MOViewRenderer>>addEdgeIn: aCollection from: source to: target model: model shape:
aShape
    ...
    self root addEdge: edge.

This was replaced with:
    (source mostSpecificParentCommonWith: target) addEdge: edge.


Still, some tests are red

Reported by tudor.girba on 2012-05-26 21:29:00

@seandenigris
Copy link
Contributor Author 

hi 

i want your help,,,,,,,,

how i can develop or create feature model tools using Mondrian

Reported by rafatals3ode on 2012-08-10 01:43:13

@seandenigris
Copy link
Contributor Author 

Thanks, Alex, for fixing the tests.

Reported by tudor.girba on 2012-08-10 07:57:53

  • Status changed: Fixed

@seandenigris
Copy link
Contributor Author 

@rafatals3ode : please ask properly for help on the mailing list.

Reported by alexandre.bergel on 2012-08-10 12:25:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seandenigris