Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugs in EyeSee #738

Closed
seandenigris opened this issue Aug 3, 2015 · 3 comments
Closed

bugs in EyeSee #738

seandenigris opened this issue Aug 3, 2015 · 3 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 738

I played with the matrix in EyeSee in a Pharo image. I found some problems:
  - #new:withAll: and #new: seems to raise an emergency debugger, whatever the value
we provide
  - Many references are made that do not belong to EyeSee. For example #zero that refers
to MalMatrixCoercion

I also found other problems (e.g., hash).
I added some tests for those. 
I produced version 0.9.2

Cheers,
Alexandre

Reported by alexandre.bergel on 2011-11-04 18:24:07
@seandenigris
Copy link
Contributor Author 

A plausible implementation of hash:

ESMalMatrix>>hash
^(self dimension hash bitXor: (self at: 1 and: 1) hash)
        bitXor: (self at: self dimension x and: self dimension y) hash

Reported by alexandre.bergel on 2011-11-04 20:49:25

@seandenigris
Copy link
Contributor Author 

ESMalMatrix is an abstract class and the initialization calls a rowSize which is a subclassResponsibility.
I do not know why the emergency evaluator happens, but it is not because of EyeSee.

In any case, ESMalMatrix should not be instantiated.

I also fixed the hash according to your suggestion.

Reported by tudor.girba on 2011-11-16 09:19:15

  • Status changed: Fixed

@seandenigris
Copy link
Contributor Author

Reported by tudor.girba on 2012-02-11 08:16:37

  • Labels added: Milestone-4.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seandenigris