Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VerveineJ should mark constructors #721

Closed
seandenigris opened this issue Aug 3, 2015 · 8 comments
Closed

VerveineJ should mark constructors #721

seandenigris opened this issue Aug 3, 2015 · 8 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 721

Constructors should be marked with isConstructor.

Reported by tudor@tudorgirba.com on 2011-10-03 15:30:09
@seandenigris
Copy link
Contributor Author 

Actually, this property is an ancient one, but it looks to not be in a clear state.

FAMIXMethod>>isConstructor is a derived property from FAMIX>>kind which in its turn
is an enumeration of:
- constructor
- getter
- setter
- constant

So, VerveineJ should export something like:
(FAMIX.Method
   ...
   (kind 'constructor')
)

In essence, Moose can also deal with the following export (that is why I said it is
not so clean):
(FAMIX.Method
   ...
   (isConstructor true)
)

In any case, independently from this issue, isConstructor should indeed be described
properly in Fame.

Reported by tudor.girba on 2011-10-04 05:25:59

  • Labels added: Milestone-4.6

@seandenigris
Copy link
Contributor Author

Reported by tudor@tudorgirba.com on 2011-10-19 10:43:07

  • Labels added: Component-VerveineJ
  • Labels removed: Component-ExternalTools

@seandenigris
Copy link
Contributor Author 

VerveineJ now add a (kind 'constructor') when required
Also added a test

Reported by anquetil.nicolas on 2011-10-19 13:21:24

  • Status changed: Fixed

@seandenigris
Copy link
Contributor Author 

It seems that using the latest version this information does not appear in the model.
So, I am reopening the issue.

Reported by tudor@tudorgirba.com on 2011-10-24 07:23:25

  • Status changed: Started

@seandenigris
Copy link
Contributor Author 

Ok. It looks like this issue is solved now for the regular cases.

However, stub constructors (both of stub and of non-stub classes) are still not marked
as constructors.

Reported by tudor@tudorgirba.com on 2011-11-09 06:34:33

@seandenigris
Copy link
Contributor Author

Reported by tudor.girba on 2012-02-11 09:46:46

  • Labels added: Milestone-4.7
  • Labels removed: Milestone-4.6

@seandenigris
Copy link
Contributor Author 

fixed and tested

Reported by anquetil.nicolas on 2012-04-13 14:17:52

  • Status changed: Fixed

@seandenigris
Copy link
Contributor Author 

Thanks

Reported by tudor.girba on 2012-04-13 19:58:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seandenigris