Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleaning package cycles #616

Closed
seandenigris opened this issue Aug 3, 2015 · 4 comments
Closed

cleaning package cycles #616

seandenigris opened this issue Aug 3, 2015 · 4 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 616

Not sure how we should implement traits but I think that

Traits TDependencyQueries, TScopingEntityQueries, TDependencyQueryResult
should have categories (protocol) beginning with '*Famix-Core-MooseChef'

Reported by jannik.laval on 2011-05-06 12:50:26
@seandenigris
Copy link
Contributor Author 

I do not understand. What is the issue here?

Reported by tudor.girba on 2011-05-07 09:08:40

@seandenigris
Copy link
Contributor Author 

In fact, for now, 
all methods copied from the traits to the classes are in a protocol named "mooseChef".

All these classes are in FAMIX-Core.
It makes a dependency from FAMIX-Core to FAMIX-Core-Moosechef.

In my analysis, I do not take into account the Traits, and I am not sure how to take
them into account.
I do not know if this is a structural issue or not.

Reported by jannik.laval on 2011-05-08 07:16:16

@seandenigris
Copy link
Contributor Author 

The problem is that Chef should be an extension, but it is not possible with Pharo because
we cannot add a Trait as an extension. So the result is that we merged Chef in Famix-Core,
but we put it in a sub category.

However, this breaks the convention of one category per package. So, we should simply
move the Traits to Famix-Core until we will get some better support for Trait extensions.

Reported by tudor.girba on 2011-05-08 17:14:31

@seandenigris
Copy link
Contributor Author

Reported by tudor.girba on 2011-05-08 20:28:49

  • Status changed: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seandenigris