Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Glamour] Transmission>>from: is said to take a port #595

Closed
seandenigris opened this issue Aug 3, 2015 · 2 comments
Closed

[Glamour] Transmission>>from: is said to take a port #595

seandenigris opened this issue Aug 3, 2015 · 2 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 595

The method GLMTransmission>>from: takes a parameter 'aPort'. However, this method is
most of the time used with a pane symbol instead of a port. This is confusing as the
Moose book says 

"
  For specifying a transmission origin that points to a #selection port
  of a pane, you simply use from:. 
"

In this case it is clear that the port is #selection and it is the default. The reader
is then waiting for an implementation similar to:

GLMTransmission>>from: aPaneSymbol
  ^ self from: aPaneSymbol port: #selection

Reported by damien.cassou on 2011-04-23 16:12:23
@seandenigris
Copy link
Contributor Author 

The problem is that beforehand we only had from: which could receive either a symbol
for the pane, or an association for the port. This was bad, and now Glamour offers
from:port:, but there are still legacy cases of from: being called with an association.

The Moose Book does not talk about this, because we want to go away from it. But, at
the moment, it won't get fixed.

Reported by tudor.girba on 2011-04-30 23:57:42

  • Labels added: Component-Glamour

@seandenigris
Copy link
Contributor Author 

For the moment, the solution is to add a comment explaining the situation.

Name: Glamour-Scripting-TudorGirba.118
Author: TudorGirba
Time: 1 May 2011, 1:57:50 am
UUID: cc6a591b-ca5c-4b56-a575-4d54bf9d5f06
Ancestors: Glamour-Scripting-TudorGirba.117

added comment to address issue http://code.google.com/p/moose-technology/issues/detail?id=595

Reported by tudor.girba on 2011-04-30 23:58:18

  • Status changed: Fixed
  • Labels added: Milestone-4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seandenigris