Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache independence #501

Closed
seandenigris opened this issue Aug 3, 2015 · 2 comments
Closed

Cache independence #501

seandenigris opened this issue Aug 3, 2015 · 2 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 501

The core of Mondrian is not independent of the cache implementation. The logic of Mondrian
rely on the cache to implement its semantics. This is obviously wrong.

-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
bounds
    "Answer the bounds of the receiver."
    "the bounds is has an absolute origin"
    "Note that the bounds computed above, may have (and it is likely to) a different origin.
The reason is that the layout is in charge to position the nodes properly"
    | basicBounds |

    boundsCache ifNotNil: [ ^ boundsCache ].

    "We check if  the shape if present"
    self shapeBoundsAt: self shape ifPresent: [ :b | ^ boundsCache := b ].

    basicBounds := self shape computeBoundsFor: self.
    self shapeBoundsAt: self shape put: basicBounds.
    ^ boundsCache := basicBounds
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
translateAbsoluteCacheBy: aPoint
    absoluteBoundsCache ifNil: [ ^ self ].
    absoluteBoundsCache := absoluteBoundsCache translateBy: aPoint
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Thanks to Santiago Vidal for pointing this out!

Reported by alexandre.bergel on 2011-01-20 13:23:51

@seandenigris
Copy link
Contributor Author

I guess this won't be tackled anymore.

Reported by tudor.girba on 2012-05-31 21:41:32

@seandenigris
Copy link
Contributor Author

Reported by alexandre.bergel on 2012-06-01 14:47:59

  • Status changed: WontFix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant