Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non embedded edges culling in Mondrian #450

Closed
seandenigris opened this issue Aug 3, 2015 · 5 comments
Closed

Non embedded edges culling in Mondrian #450

seandenigris opened this issue Aug 3, 2015 · 5 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 450

Currently, all the non-embedded edges are displayed. However, if the window is not between
the two extremity, then there is no point in drawing the edge. Something that I should
implement.

Thanks Henrik Sperre Johansen <henrik.s.johansen@veloxit.no> for this suggestion

Reported by alexandre.bergel on 2010-09-03 12:53:42
@seandenigris
Copy link
Contributor Author 

In the version 2.30 of Mondrian

Reported by alexandre.bergel on 2011-01-10 20:50:08

  • Status changed: Fixed

@seandenigris
Copy link
Contributor Author 

Sounds great. What is the impact on speed for a large visualization?

Reported by tudor.girba on 2011-01-10 21:10:35

  • Labels added: Milestone-4.3

@seandenigris
Copy link
Contributor Author 

I did some benchmark, but I am not sure on how close they are to the reality.
I generated the blueprint of the AST classes. 
Doing 100 repaints of take 9214 ms without the improvement. It takes 6045 with. 

To obtain the canvas, I put a "self haltOnce" in MORoot>>displayOn:

Reported by alexandre.bergel on 2011-01-11 15:46:28

@seandenigris
Copy link
Contributor Author 

Nice

Reported by tudor.girba on 2011-01-15 13:43:45

@seandenigris
Copy link
Contributor Author 

it works. But it can be optimized I think. For example, I check if the bounds given
by the current window frame intersect the rectangle bounds of the edge. This is clearly
not optimal since we should check if the line crosses the window frame.

Reported by alexandre.bergel on 2011-01-16 00:54:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seandenigris