Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cook issues noted in MooseChef #438

Closed
seandenigris opened this issue Aug 3, 2015 · 8 comments
Closed

Cook issues noted in MooseChef #438

seandenigris opened this issue Aug 3, 2015 · 8 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 438

- Could not find tests for #isSurelyInvoked: and #sureIncomingInvocations (check Visualworks
packages?)

- FamixMethod>>invokedPackages would also add packages from sureReferencedClasses.
This is wrong if we follow a strict definition that invokedPackages only return packages
for which we call methods (for example, if we call method PackageA::ClassX>>foo from
*PExtensions, the spec says we depend on PExtensions through #foo invocation, not on
PackageA from ClassX. See testReferencedPackages for FamixMethod)

Reported by simon.denier on 2010-08-27 14:45:36
@seandenigris
Copy link
Contributor Author 

- No query/tests about variable access?

Reported by simon.denier on 2010-08-27 14:58:03

@seandenigris
Copy link
Contributor Author

Reported by simon.denier on 2010-08-27 15:17:03

@seandenigris
Copy link
Contributor Author 

Continuing test trials with Jannik, queries for targets and scopes are the most used
and should be short to call and straightforward. The final API would look like this:

#incoming:
#incoming:as:
#incoming:scope:
#incomingAssociations
#outgoing:
#outgoing:as:
#outgoing:scope:
#outgoingAssociations:
#filter:withPackage:
#filter:withClass:
...
#filterAssociations:withPackage:
#filterAssociations:withClass:
...

Reported by simon.denier on 2010-08-27 15:20:56

@seandenigris
Copy link
Contributor Author 

Is this issue up to date?

Reported by tudor.girba on 2011-01-23 00:19:14

@seandenigris
Copy link
Contributor Author 

Yes, I will see to close it with MooseChef

Reported by simon.denier on 2011-01-24 21:56:42

@seandenigris
Copy link
Contributor Author

Reported by jannik.laval on 2011-01-28 12:11:40

  • Labels added: Milestone-4.2

@seandenigris
Copy link
Contributor Author

Reported by tudor.girba on 2011-01-28 12:13:42

  • Labels added: Milestone-4.3
  • Labels removed: Milestone-4.2

@seandenigris
Copy link
Contributor Author

Reported by tudor.girba on 2011-02-04 23:16:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seandenigris