Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Writing informations in a Transcript #417

Closed
seandenigris opened this issue Aug 3, 2015 · 9 comments
Closed

Writing informations in a Transcript #417

seandenigris opened this issue Aug 3, 2015 · 9 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 417

Some tools (like Mondrian for example) are always writing informations in the transcript.

If this one is opened, it take a lot a time to do some actions.
Would it be a good idea to remove those Transcript-accesses ?

Reported by cy.delaunay on 2010-06-16 14:34:16
@seandenigris
Copy link
Contributor Author 

Indeed, we should not write on the Transcript.

Reported by tudor.girba on 2010-06-17 12:46:14

  • Labels added: Component-MooseCore, Component-Mondrian

@seandenigris
Copy link
Contributor Author 

I guess one should expect this kind of comments when an unstable version is published
:-)
The use of the transcript was for tracking some of the problems. It is now removed
in the last version of Mondrian.

Reported by alexandre.bergel on 2010-06-17 13:54:15

  • Status changed: Fixed

@seandenigris
Copy link
Contributor Author 

No stress :). I guess there are still uses in the rest of the Moose code base. We should
have a rule to identify these.

Reported by tudor.girba on 2010-06-17 14:05:33

@seandenigris
Copy link
Contributor Author

Reported by jannik.laval on 2010-06-17 15:24:53

  • Status changed: Started

@seandenigris
Copy link
Contributor Author 

There is no "Transcript show:" in Mondrian.
Glamour contains some Transcript show. E.g., simpleActionList, actionsFor:, staticAndDynamicMenu.
I have the impression the transcript>>show: is okay here.
However, GLMFinger>>innerPortEvent: can be cleaned. Doru, can you confirm? I can remove
the transcript reference. 

The LAN example has also some reference. We could maybe refactor them to write in a
particular stream or something. This will make the testing easier also.

If this is okay with you guys, I will clean:
MooseAbstractGroup>>computeDuplication

However, the good news, is that there isn't many calls to #show:

Reported by alexandre.bergel on 2010-09-13 14:33:27

@seandenigris
Copy link
Contributor Author 

I cleaned GLMFinder

Reported by tudor.girba on 2010-09-13 16:27:34

@seandenigris
Copy link
Contributor Author 

Mondrian contains just one "Transcript show:", when doing the benchmark. I consider
it acceptable

Reported by alexandre.bergel on 2011-04-06 17:30:22

  • Labels removed: Component-Mondrian

@seandenigris
Copy link
Contributor Author 

This issue can be considered fixed. There are only a couple of places that still have
this around, but for good reason. We also have a rule for this:
http://ci.moosetechnology.org/job/moose-on-moose/lastCompletedBuild/testReport/(root)/OnMooseTranscriptUsages/_Transcript_usages_/

Reported by tudor.girba on 2011-11-16 08:59:27

  • Status changed: Fixed
  • Labels added: Maintainability

@seandenigris
Copy link
Contributor Author

Reported by tudor.girba on 2011-11-16 08:59:37

  • Labels added: Milestone-4.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seandenigris