Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local node lookup should stay local #400

Closed
seandenigris opened this issue Aug 3, 2015 · 1 comment
Closed

Local node lookup should stay local #400

seandenigris opened this issue Aug 3, 2015 · 1 comment

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 400

The following method is used for controling the scope of edge definition.
However, the problem is that if the target node is not found locally, the
search is restarted globally.

localLookupNode: aModel

^ self root 
    nodeWith: aModel    
    ifAbsent: [ self root 
        firstSubnodeThat: [:aNode | aNode model = aModel] 
        ifAbsent: [ self root root
           firstSubnodeThat: [:aNode | aNode model = aModel] ] ]

This should not happen. So, the last ifAbsent: should be removed. I tried
to remove it, but it looks like two tests related to adding edges through
interaction break. I do not understand why, so I left the original code for
now.

Reported by tudor.girba on 2010-05-12 12:27:58

@seandenigris
Copy link
Contributor Author

Mondrian is obsolete.

Reported by tudor@tudorgirba.com on 2013-11-11 22:21:15

  • Status changed: WontFix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant