Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complex form shapes cannot be drawn when inside another node #319

Closed
seandenigris opened this issue Aug 3, 2015 · 3 comments
Closed

Complex form shapes cannot be drawn when inside another node #319

seandenigris opened this issue Aug 3, 2015 · 3 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 319

The following code fails to draw the nodes properly: all classes are drawn on top of
each other. 
However, the nodes do have the internal state correctly set by the horizontal line
layout. This can 
be seen by the size of the parent node and by clicking somewhere in the white space.

| builder |
builder := MOFormsBuilder new.
builder column; fill.
builder row; fill; row; fill.
builder x: 1 y: 1 add: MORectangleShape new.
builder x: 1 y: 1 add: (MOLabelShape new text: [ :cls | cls name ]).
builder x: 1 y: 2 add: MORectangleShape new.

view node: 1 forIt: [
    view shape: builder shape.
    view nodes: classGroup.
]

Reported by tudor.girba on 2010-02-16 20:56:26
@seandenigris
Copy link
Contributor Author 

Name: Mondrian-Alexandre_Bergel.366
Author: Alexandre Bergel
Time: 18 February 2010, 1:44:56 am
UUID: 7a842f26-b887-4342-bb53-6e254dda0152
Ancestors: Mondrian-Alexandre_Bergel.365

Mondrian-Alexandre_Bergel.366

Before this version, form builder could not be embedded in a subview. 
The reason is that asking what is the size of a form shape triggered a new recomputation
of each bounds 
shape. Therefore, all the subnodes form shape appeared to be at the same location.
MOFormsShape>>widthFor: and heightFor: simply lookup in cacheShapeBounds instead of
recomputing the 
whole thing.

Naturally, a test has been added to MOFormsBuilderTest .

This f**king beast entertained my long evening. But at least, I got rid of it.

In addition to this, 

This version addressed the issue #319

Reported by alexandre.bergel on 2010-02-18 05:04:38

@seandenigris
Copy link
Contributor Author 

Doru, I leave this issue open. Even though I wrote a test for this, you may want to
be sure this is really fixed.

Reported by alexandre.bergel on 2010-02-18 05:05:54

@seandenigris
Copy link
Contributor Author 

It looks like it is fixed.

Reported by tudor.girba on 2010-03-01 21:20:33

  • Status changed: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seandenigris