Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infer declaredType of FamixAttribute in SmalltalkImporter #224

Closed
seandenigris opened this issue Aug 3, 2015 · 5 comments
Closed

Infer declaredType of FamixAttribute in SmalltalkImporter #224

seandenigris opened this issue Aug 3, 2015 · 5 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 224

It would be great if the importer could infer some type information about the attributes
(or other 
variables) of imported classes. One way could be to use the RoelTyper.

Reported by simon.denier on 2009-11-18 23:50:52
@seandenigris
Copy link
Contributor Author

Reported by simon.denier on 2009-12-03 13:41:28

  • Labels added: Type-Project
  • Labels removed: Type-Enhancement

@seandenigris
Copy link
Contributor Author 

This is done.
As it can take some time to compute the type of an attribute (with roelTyper), I had
to keep the possibility to not 
compute the type of attributes. To do that, I added some methods to ImportingContext,
specifying if the 
importer have to compute or not the type of attributes. Then, in SmalltalkImporter,
we check the 
importingContext to know if we compute or not the types. Is it a good way to do that?
I also updated the wizard so that we can choose the solution we want. By default it
doesn't compute anything.

Reported by cy.delaunay on 2010-04-27 15:05:42

@seandenigris
Copy link
Contributor Author 

Yes, seems a good solution.

Do you have tests? We can take a look at that.

Also, if the computation takes long, we may choose to bypass the computation at import
(like you have) but later 
compute types on a subset of classes. That is, add a UI command on FamixClass and FamixClassGroup.

Reported by simon.denier on 2010-04-28 09:05:01

  • Status changed: Started
  • Labels added: Type-Enhancement
  • Labels removed: Type-Project

@seandenigris
Copy link
Contributor Author 

We need tests for this one. The RoelTyper does not work properly.

Reported by tudor.girba on 2011-04-26 20:51:52

@seandenigris
Copy link
Contributor Author 

This is fixed in the latest version. If there more issues, we can open more detailed
entries.

Reported by tudor@tudorgirba.com on 2011-07-12 13:37:20

  • Status changed: Fixed
  • Labels added: Milestone-4.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seandenigris