Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename in Famix-Extensions "referenced/referencing" to "invoked/invoking" #175

Closed
seandenigris opened this issue Aug 3, 2015 · 9 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 175

For example:
FAMIXMethod>>referencedMethods -> invokedMethods

Reported by tudor.girba on 2009-09-26 22:31:50

@seandenigris
Copy link
Contributor Author

Reported by tudor.girba on 2009-11-16 05:10:53

  • Labels added: Milestone-4.1
  • Labels removed: Milestone-4.0

@seandenigris
Copy link
Contributor Author

Reported by simon.denier on 2009-12-03 13:27:52

  • Labels added: Type-Engineering
  • Labels removed: Type-Defect

@seandenigris
Copy link
Contributor Author

Today I stumble upon

FAMIXPackage>>clientPackages
    ^ self inheritedByPackages union: self invokingPackages

which seems wrong because it does not take into account referencing packages. Checking
with Hani, it is self 
referencingPackages instead of self invokingPackages in VW. My guess is that the renaming
went wrong.

Reported by simon.denier on 2009-12-14 16:33:27

@seandenigris
Copy link
Contributor Author

Could someone go through this one again?

Reported by tudor.girba on 2010-09-05 09:18:02

@seandenigris
Copy link
Contributor Author

Well I feel cold about this:
- for one thing, changing that requires checking that all updated call sites - tedious,
and I'm afraid we will lose time asking in some cases whether it makes sense to call
that or that
- for another thing, that's exactly why we undertook the MooseChef project with Jannik,
which aim at clarifying all this stuff and providing clear and simple semantics

In other words, it works fine for now, we may break things in unexpected way if we
change, and we plan to replace/rewrite it in 4.2 with MooseChef. So I would not make
it a requirement for 4.1

Reported by simon.denier on 2010-09-05 18:59:32

@seandenigris
Copy link
Contributor Author

Ok. It's great to hear that MooseChef is scheduled for 4.2 :).

I marked the issue for 4.2

Reported by tudor.girba on 2010-09-05 19:10:51

  • Labels added: Milestone-4.2
  • Labels removed: Milestone-4.1

@seandenigris
Copy link
Contributor Author

This should go away when MooseChef is integrated. I would close it for now.

Reported by tudor.girba on 2011-01-28 12:22:03

  • Labels added: Milestone-4.3
  • Labels removed: Milestone-4.2

@seandenigris
Copy link
Contributor Author

Actually I'm thinking of marking it as invalid now. We will get rid of all cook methods
and their ambiguous names, just rewrite some like client... provider...

Reported by simon.denier on 2011-01-28 20:55:17

@seandenigris
Copy link
Contributor Author

Reported by simon.denier on 2011-02-01 21:14:13

  • Status changed: Invalid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant