Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't export as PNG with Roassal export button #1056

Closed
seandenigris opened this issue Aug 3, 2015 · 7 comments
Closed

Can't export as PNG with Roassal export button #1056

seandenigris opened this issue Aug 3, 2015 · 7 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 1056

Describe the problem: what do you get? what do you expect?

When you add the export button, on a Roassal view and you select PNG export, you get:
MessageNotUnderstood: ROAthensImageExporter class>>subclassRespondibility

How to reproduce the problem: step by step if necessary

ROMondrianViewBuilder new exportButton ; open.

Clic on Export and Export as PNG.

Additional information: platform, context which may impact the problem

Moose 5.0 - W7

Please fill in the labels with the following information:
* Type-Defect
* Component-Roassal

Reported by v.blondeau92 on 2014-03-19 12:46:18

@seandenigris
Copy link
Contributor Author

Fixed in the attached file.

There is another issue: 

when you export in PNG, the image exported contains only the visible objects in the
Roassal window. But the image size is like all the visualisation (with the hidden parts)
will be exported.

Reported by v.blondeau92 on 2014-03-19 12:52:30


- _Attachment: [RoassalAthens-VincentBlondeau.20.mcz](https://storage.googleapis.com/google-code-attachments/moose-technology/issue-1056/comment-1/RoassalAthens-VincentBlondeau.20.mcz)_

@seandenigris
Copy link
Contributor Author

And even when you change the size of the Roassal window, the exported image is always
of the same size...

The solution I propose is to export all the elements of the view, hidden or not.
See the attached fix.

However the tests ROMorphTest>>testBitmapSize and testImageForm have to be modified
to not fail.

Reported by v.blondeau92 on 2014-03-19 13:32:03


- _Attachment: [RoassalMorphic-VincentBlondeau.172.mcz](https://storage.googleapis.com/google-code-attachments/moose-technology/issue-1056/comment-2/RoassalMorphic-VincentBlondeau.172.mcz)_

@seandenigris
Copy link
Contributor Author

I integrated these changes now and it works. Thanks.

As you said, the two tests are failing. Can you provide correct versions of these tests?

Reported by tudor@tudorgirba.com on 2014-07-10 04:59:21

  • Labels added: Component-Roassal

@seandenigris
Copy link
Contributor Author

Yes! The tests are attached

Reported by v.blondeau92 on 2014-07-15 09:03:51


- _Attachment: [RoassalMorphic-VincentBlondeau.173.mcz](https://storage.googleapis.com/google-code-attachments/moose-technology/issue-1056/comment-4/RoassalMorphic-VincentBlondeau.173.mcz)_

@seandenigris
Copy link
Contributor Author

Thanks! I integrated them now.

Reported by tudor@tudorgirba.com on 2014-07-23 20:58:52

  • Labels added: Milestone-5.0

@seandenigris
Copy link
Contributor Author

Reported by tudor@tudorgirba.com on 2014-07-24 05:15:37

  • Status changed: Fixed

@seandenigris
Copy link
Contributor Author

Issue 995 has been merged into this issue.

Reported by tudor@tudorgirba.com on 2014-07-24 05:16:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant