Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl + S and Alt + S haven't the same behaviour #1036

Closed
seandenigris opened this issue Aug 3, 2015 · 7 comments
Closed

Ctrl + S and Alt + S haven't the same behaviour #1036

seandenigris opened this issue Aug 3, 2015 · 7 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 1036

Describe the problem: what do you get? what do you expect?

To save the modified source code in the debugger under Pharo3.0, we can make Ctrl +
S or Alt + S. 

But with the latest version of Moose5.0. Alt + S save the source and move the stack
to the saved method. Ctrl + S only save the source.

How to reproduce the problem: step by step if necessary

Open a debugger, select an other method in the stack trace, modify it.
Try to save with Ctrl + S and do it again with Alt + S.

Additional information: platform, context which may impact the problem

Windows 7 x64 and Linux Ubuntu x64

Please fill in the labels with the following information:
* Type-Defect
* Component-GTDebugger
* Milestone-5.0

Reported by v.blondeau92 on 2013-12-21 19:00:27
@seandenigris
Copy link
Contributor Author 

This Ctrl+s problem is so annoying and it's a morph problem. I do not have a Windows
machine nearby, but could you try to see if Ctrl+s/Alt+s work in the code browser as
expected?

Reported by tudor@tudorgirba.com on 2013-12-22 10:29:20

@seandenigris
Copy link
Contributor Author 

I have no problems in code browser.

But I have the problem in debugger:
Alt+s saves the code as expected.
Ctrl+s looks like it saved the code (it changes in the debugger) but the change is
not visible in browser and next time the debugger pops up the change is not visible.

This makes me crazy :)

I use Linux Ubuntu x64

Reported by kurs.jan on 2014-01-06 10:37:30

@seandenigris
Copy link
Contributor Author 

I hate this mess with text morph. Ctrl+s comes from the low level text morph. This binding
should not exist actually, and everything would be fine.

I have to check on Windows, too.

Reported by tudor@tudorgirba.com on 2014-01-06 20:37:09

  • Labels added: Component-Glamour, Milestone-5.0

@seandenigris
Copy link
Contributor Author 

I lost some lines of code because of this bug....

I suggest to overload GLMTextMorphForEditView>>acceptContents with an empty method.
By this way, the code will not seem to be saved.

But if we close the window containing modified code, no message is displayed. 
Can we display such a message ?

Reported by v.blondeau92 on 2014-01-15 17:13:51

@seandenigris
Copy link
Contributor Author 

I committed the change I suggested.
It's in Glamour-Morphic-Widgets version 77.

It's a temporary hack only...

Reported by v.blondeau92 on 2014-02-04 14:52:00

@seandenigris
Copy link
Contributor Author 

Thanks!

I will test it tomorrow on a Windows machine. Can anyone else take a look as well on
Windows and Linux?

Reported by tudor@tudorgirba.com on 2014-02-04 14:59:18

@seandenigris
Copy link
Contributor Author 

It works fine. Ctrl+s is disabled on Windows.

Reported by tudor@tudorgirba.com on 2014-02-05 11:24:55

  • Status changed: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seandenigris