Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The treemap builder should offer a default weight of 1 #1003

Closed
seandenigris opened this issue Aug 3, 2015 · 2 comments
Closed

The treemap builder should offer a default weight of 1 #1003

seandenigris opened this issue Aug 3, 2015 · 2 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 1003

Right now, the weight block has to be specified. Instead, we should have a default weight
of 1. Furthermore, right now, if the weight returns 0 (like above), we get a ZeroDivide.
Zero should be handled without an error.

Reported by tudor@tudorgirba.com on 2013-11-15 05:25:25
@seandenigris
Copy link
Contributor Author 

Also, the weight should ideally be aggregated from leaf nodes. For example, the code
below makes packages have only 1 weight, and thus the classes appear tiny and empty
packages appear as large as non empty ones. If we would have a way to specify aggregation,
we would be better off.

| builder rawView packages | 
builder := ROTreeMapBuilder new.
rawView := ROView new.
packages := self mooseModel allNamespaces.
builder weightBlock: [ :el | (el isKindOf: FAMIXType) ifTrue: [ el numberOfMethods
+ 1] ifFalse: [ 1 ] ].
builder nodes: (packages), (self).
builder nestingFromAssociations:
    (builder nodes collect: [ :each | 
            each parentScope -> each ]).
builder drawOn: rawView.
rawView open

Reported by tudor@tudorgirba.com on 2013-11-15 07:16:11

@seandenigris
Copy link
Contributor Author 

Roassal1 is no longer supported

Reported by tudor@tudorgirba.com on 2014-11-13 21:41:21

  • Status changed: WontFix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seandenigris