modtelemetry - Project Hosting on Google Code

Older Nov 14, 2009 issue 7 (some compile warnings) reported by po...@cmdline.net - There is a number of warnings that my compiler (here: openSUSE 11.1) issues, all of which are probably worth fixing: /usr/lib/apr-1/build/libtool --silent --mode=compile gcc -prefer-pic -march=i586 -mtune=i686 - fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous- unwind-tables -g -fPIC -Wall -fno-strict-aliasing -DLDAP_DEPRECATED -DLINUX=2 -D_REENTRANT - D_GNU_SOURCE -D_LARGEFILE64_SOURCE -pthread -I/usr/include/apache2 -I/usr/include/apr-1 - I/usr/include/apr-1 -DVERSION=1.0 -c -o mod_telemetry.lo mod_telemetry.c && touch mod_telemetry.slo mod_telemetry.c: In function 'djbhash': mod_telemetry.c:138: warning: suggest parentheses around assignment used as truth value mod_telemetry.c: In function 'stristr': mod_telemetry.c:217: warning: implicit declaration of function 'toupper' mod_telemetry.c: In function 'modtelemetry_log': mod_telemetry.c:284: warning: pointer targets in passing argument 1 of 'djbhash' differ in signedness mod_telemetry.c:252: warning: unused variable 'start' mod_telemetry.c: In function 'reset_counters': mod_telemetry.c:358: warning: 'return' with a value, in function returning void mod_telemetry.c:366: warning: 'return' with a value, in function returning void mod_telemetry.c:377: warning: 'return' with a value, in function returning void mod_telemetry.c:353: warning: unused variable 't' mod_telemetry.c:352: warning: unused variable 'tmstat' mod_telemetry.c: In function 'tm_report': mod_telemetry.c:593: warning: implicit declaration of function 'apr_psprintf' mod_telemetry.c:494: warning: unused variable 'indices' mod_telemetry.c: In function 'modtelemetry_handle': mod_telemetry.c:632: warning: unused variable 'start' mod_telemetry.c: In function 'modtelemetry_post_config': mod_telemetry.c:753: warning: format '%s' expects type 'char ', but argument 7 has type 'double' mod_telemetry.c:700: warning: unused variable 't' mod_telemetry.c:699: warning: unused variable 'tmstat' mod_telemetry.c: At top level: mod_telemetry.c:165: warning: 'show_apr_time' defined but not used /usr/lib/apr-1/build/libtool --silent --mode=link gcc -o mod_telemetry.la -rpath /usr/lib/apache2 -module -avoid-version mod_telemetry.lo + exit 0 There is a number of warnings that my compiler (here: openSUSE 11.1) issues, all of which are probably worth fixing: /usr/lib/apr-1/build/libtool --silent --mode=compile gcc -prefer-pic -march=i586 -mtune=i686 - fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous- unwind-tables -g -fPIC -Wall -fno-strict-aliasing -DLDAP_DEPRECATED -DLINUX=2 -D_REENTRANT - D_GNU_SOURCE -D_LARGEFILE64_SOURCE -pthread -I/usr/include/apache2 -I/usr/include/apr-1 - I/usr/include/apr-1 -DVERSION=1.0 -c -o mod_telemetry.lo mod_telemetry.c && touch mod_telemetry.slo mod_telemetry.c: In function 'djbhash': mod_telemetry.c:138: warning: suggest parentheses around assignment used as truth value mod_telemetry.c: In function 'stristr': mod_telemetry.c:217: warning: implicit declaration of function 'toupper' mod_telemetry.c: In function 'modtelemetry_log': mod_telemetry.c:284: warning: pointer targets in passing argument 1 of 'djbhash' differ in signedness mod_telemetry.c:252: warning: unused variable 'start' mod_telemetry.c: In function 'reset_counters': mod_telemetry.c:358: warning: 'return' with a value, in function returning void mod_telemetry.c:366: warning: 'return' with a value, in function returning void mod_telemetry.c:377: warning: 'return' with a value, in function returning void mod_telemetry.c:353: warning: unused variable 't' mod_telemetry.c:352: warning: unused variable 'tmstat' mod_telemetry.c: In function 'tm_report': mod_telemetry.c:593: warning: implicit declaration of function 'apr_psprintf' mod_telemetry.c:494: warning: unused variable 'indices' mod_telemetry.c: In function 'modtelemetry_handle': mod_telemetry.c:632: warning: unused variable 'start' mod_telemetry.c: In function 'modtelemetry_post_config': mod_telemetry.c:753: warning: format '%s' expects type 'char ', but argument 7 has type 'double' mod_telemetry.c:700: warning: unused variable 't' mod_telemetry.c:699: warning: unused variable 'tmstat' mod_telemetry.c: At top level: mod_telemetry.c:165: warning: 'show_apr_time' defined but not used /usr/lib/apr-1/build/libtool --silent --mode=link gcc -o mod_telemetry.la -rpath /usr/lib/apache2 -module -avoid-version mod_telemetry.lo + exit 0 Nov 14, 2009 issue 6 (unclear note about mod_scoreboard) reported by po...@cmdline.net - The header of mod_telemetry.c contains the following note: THIS MODULE REQUIRES THAT MOD_SCOREBOARD BE ENABLED. However, it is not clear what mod_scoreboard is. I don't find it in Google. It is not a standard module that ships with Apache. What is mod_scoreboard? (I see something on http://html.conclase.net/cp/scripts/ but how do I know if it's the correct one, or if I need to look further.) Clarifying this dependency would be useful. Thanks. The header of mod_telemetry.c contains the following note: THIS MODULE REQUIRES THAT MOD_SCOREBOARD BE ENABLED. However, it is not clear what mod_scoreboard is. I don't find it in Google. It is not a standard module that ships with Apache. What is mod_scoreboard? (I see something on http://html.conclase.net/cp/scripts/ but how do I know if it's the correct one, or if I need to look further.) Clarifying this dependency would be useful. Thanks. Nov 14, 2009 issue 5 (compiler error due to incomplete format string) reported by po...@cmdline.net - On certain platforms, I get the following error when trying to compile: I: Function call is passing too few arguments to a printf function. W: apache2-mod_telemetry missing-arg-for-fmt-string mod_telemetry.c:177 Correctly, the compiler complains about the following: sprintf(mystr, "%02d:%02d:%02d.%02d",hrs,mins,secs); (I highly recommend to always use -Wall (or even -Werror) when compiling.) On certain platforms, I get the following error when trying to compile: I: Function call is passing too few arguments to a printf function. W: apache2-mod_telemetry missing-arg-for-fmt-string mod_telemetry.c:177 Correctly, the compiler complains about the following: sprintf(mystr, "%02d:%02d:%02d.%02d",hrs,mins,secs); (I highly recommend to always use -Wall (or even -Werror) when compiling.) Nov 14, 2009 issue 4 (reset_counters() function not declared quite correctly) reported by po...@cmdline.net - I get the following compile error on certain platforms: I: Program returns random data in a function E: apache2-mod_telemetry no-return-in-nonvoid-function mod_telemetry.c:383 It's true, the function reset_counters is declared "static int", but its return value is not used. It should be a void function. I get the following compile error on certain platforms: I: Program returns random data in a function E: apache2-mod_telemetry no-return-in-nonvoid-function mod_telemetry.c:383 It's true, the function reset_counters is declared "static int", but its return value is not used. It should be a void function. Nov 14, 2009 issue 3 (Compile error due to missing VERSION) reported by po...@cmdline.net - While packaging mod_telemetry for openSUSE, I noticed a little problem. When I run apxs -c mod_telemetry.c The compile aborts because the symbol "VERSION" is not known. If I define the symbol by running apxs -DVERSION=%{version} -c mod_telemetry.c the compile finishes fine. While packaging mod_telemetry for openSUSE, I noticed a little problem. When I run apxs -c mod_telemetry.c The compile aborts because the symbol "VERSION" is not known. If I define the symbol by running apxs -DVERSION=%{version} -c mod_telemetry.c the compile finishes fine. Oct 14, 2008 issue 2 (Segmentation fault with apache 2.2.9) reported by il...@altervista.org - What steps will reproduce the problem? 1. after installing mod_telemetry each http request causa a segmentation fault What is the expected output? What do you see instead? I find a "[Tue Oct 14 08:47:01 2008] [notice] child pid 9445 exit signal Segmentation fault (11)" in error log file What version of the product are you using? On what operating system? Apache httpd 2.2.9 ModTelemetry 1.0 Linux Suse with kernel 2.6.18 Please provide any additional information below. Http server error log in attached file What steps will reproduce the problem? 1. after installing mod_telemetry each http request causa a segmentation fault What is the expected output? What do you see instead? I find a "[Tue Oct 14 08:47:01 2008] [notice] child pid 9445 exit signal Segmentation fault (11)" in error log file What version of the product are you using? On what operating system? Apache httpd 2.2.9 ModTelemetry 1.0 Linux Suse with kernel 2.6.18 Please provide any additional information below. Http server error log in attached file

issue 7 (some compile warnings) reported by po...@cmdline.net - There is a number of warnings that my compiler (here: openSUSE 11.1) issues, all of which are probably worth fixing: /usr/lib/apr-1/build/libtool --silent --mode=compile gcc -prefer-pic -march=i586 -mtune=i686 - fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous- unwind-tables -g -fPIC -Wall -fno-strict-aliasing -DLDAP_DEPRECATED -DLINUX=2 -D_REENTRANT - D_GNU_SOURCE -D_LARGEFILE64_SOURCE -pthread -I/usr/include/apache2 -I/usr/include/apr-1 - I/usr/include/apr-1 -DVERSION=1.0 -c -o mod_telemetry.lo mod_telemetry.c && touch mod_telemetry.slo mod_telemetry.c: In function 'djbhash': mod_telemetry.c:138: warning: suggest parentheses around assignment used as truth value mod_telemetry.c: In function 'stristr': mod_telemetry.c:217: warning: implicit declaration of function 'toupper' mod_telemetry.c: In function 'modtelemetry_log': mod_telemetry.c:284: warning: pointer targets in passing argument 1 of 'djbhash' differ in signedness mod_telemetry.c:252: warning: unused variable 'start' mod_telemetry.c: In function 'reset_counters': mod_telemetry.c:358: warning: 'return' with a value, in function returning void mod_telemetry.c:366: warning: 'return' with a value, in function returning void mod_telemetry.c:377: warning: 'return' with a value, in function returning void mod_telemetry.c:353: warning: unused variable 't' mod_telemetry.c:352: warning: unused variable 'tmstat' mod_telemetry.c: In function 'tm_report': mod_telemetry.c:593: warning: implicit declaration of function 'apr_psprintf' mod_telemetry.c:494: warning: unused variable 'indices' mod_telemetry.c: In function 'modtelemetry_handle': mod_telemetry.c:632: warning: unused variable 'start' mod_telemetry.c: In function 'modtelemetry_post_config': mod_telemetry.c:753: warning: format '%s' expects type 'char *', but argument 7 has type 'double' mod_telemetry.c:700: warning: unused variable 't' mod_telemetry.c:699: warning: unused variable 'tmstat' mod_telemetry.c: At top level: mod_telemetry.c:165: warning: 'show_apr_time' defined but not used /usr/lib/apr-1/build/libtool --silent --mode=link gcc -o mod_telemetry.la -rpath /usr/lib/apache2 -module -avoid-version mod_telemetry.lo + exit 0

There is a number of warnings that my compiler (here: openSUSE 11.1) issues, all of which are probably worth fixing: /usr/lib/apr-1/build/libtool --silent --mode=compile gcc -prefer-pic -march=i586 -mtune=i686 - fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous- unwind-tables -g -fPIC -Wall -fno-strict-aliasing -DLDAP_DEPRECATED -DLINUX=2 -D_REENTRANT - D_GNU_SOURCE -D_LARGEFILE64_SOURCE -pthread -I/usr/include/apache2 -I/usr/include/apr-1 - I/usr/include/apr-1 -DVERSION=1.0 -c -o mod_telemetry.lo mod_telemetry.c && touch mod_telemetry.slo mod_telemetry.c: In function 'djbhash': mod_telemetry.c:138: warning: suggest parentheses around assignment used as truth value mod_telemetry.c: In function 'stristr': mod_telemetry.c:217: warning: implicit declaration of function 'toupper' mod_telemetry.c: In function 'modtelemetry_log': mod_telemetry.c:284: warning: pointer targets in passing argument 1 of 'djbhash' differ in signedness mod_telemetry.c:252: warning: unused variable 'start' mod_telemetry.c: In function 'reset_counters': mod_telemetry.c:358: warning: 'return' with a value, in function returning void mod_telemetry.c:366: warning: 'return' with a value, in function returning void mod_telemetry.c:377: warning: 'return' with a value, in function returning void mod_telemetry.c:353: warning: unused variable 't' mod_telemetry.c:352: warning: unused variable 'tmstat' mod_telemetry.c: In function 'tm_report': mod_telemetry.c:593: warning: implicit declaration of function 'apr_psprintf' mod_telemetry.c:494: warning: unused variable 'indices' mod_telemetry.c: In function 'modtelemetry_handle': mod_telemetry.c:632: warning: unused variable 'start' mod_telemetry.c: In function 'modtelemetry_post_config': mod_telemetry.c:753: warning: format '%s' expects type 'char *', but argument 7 has type 'double' mod_telemetry.c:700: warning: unused variable 't' mod_telemetry.c:699: warning: unused variable 'tmstat' mod_telemetry.c: At top level: mod_telemetry.c:165: warning: 'show_apr_time' defined but not used /usr/lib/apr-1/build/libtool --silent --mode=link gcc -o mod_telemetry.la -rpath /usr/lib/apache2 -module -avoid-version mod_telemetry.lo + exit 0

Older