You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
To facilitate sharing doc with ngx_pagespeed we should enable
pagespeed EnableFilters extend_cache,rewrite_images
as a synonym for
ModPagespeed EnableFilters extend_cache,rewrite_images
Note that this will still not be fully compatible as the ngx_pagespeed as nginx
commands require semi-colon termination.
Original issue reported on code.google.com by jmara...@google.com on 16 Apr 2013 at 10:57
The text was updated successfully, but these errors were encountered:
We /could/ strip a final semicolon. Other than REs and URLs I don't think they
are significant. For REs and URLs we could just chance it and strip them anyway?
Original comment by matterb...@google.com on 17 Apr 2013 at 12:49
Although stripping the trailing semicolon, sounds really confusing to me. If
you are familiar with Apache, you'll be really confused by why our command end
in ; and others don't.
Perhaps we could just say that the command is "pagespeed EnableFilters
extend_cache,rewrite_images" and Apache people would know that that means it
needs to be on it's own line and nginx people would know it needs to be
;-terminated?
Original comment by sligocki@google.com on 17 Apr 2013 at 3:27
I agree 100% /but/ if we have a use-case where some site wants to share a
config file between nginx and Apache (which admittedly does sound bizarre :)
this would help. Perhaps it could be documented that it's done for Apache but
not include it everywhere. Or perhaps enable it with yet-another directive that
the bizarre site admin would have to add while everyone else just does the
usual thing.
Original comment by matterb...@google.com on 17 Apr 2013 at 3:31
Yeah I'm not a fan of stripping the semicolon in Apache. We can simply put in
the ngx doc that all commands should be suffixed with a semicolon.
If it's easy we can put in a greyed-out semi-colon that when you hover over it
popups up tooltip "in nginx add semi-colon, in apache don't".
Original comment by jmara...@google.com on 17 Apr 2013 at 3:32
Original issue reported on code.google.com by
jmara...@google.com
on 16 Apr 2013 at 10:57The text was updated successfully, but these errors were encountered: