Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Javascript inside IE comments does not obey defer_javascript filter #602

Open
GoogleCodeExporter opened this issue Apr 6, 2015 · 2 comments
Open

Javascript inside IE comments does not obey defer_javascript filter #602

GoogleCodeExporter opened this issue Apr 6, 2015 · 2 comments
Labels
auto-migrated Priority-Medium Type-Defect

Comments

@GoogleCodeExporter
Copy link 

Using the latest development version of mod_pagespeed, if you place some 
javascript within an IE comment block, it is ignored by the defer_javascript 
filter.

This can cause issues where it is reliant on various javascripts having been 
loaded previously.

If the code is not within an IE comment block, it gets deferred as you would 
expect and there are no problems.

Original issue reported on code.google.com by rwap.services on 8 Jan 2013 at 10:27
@GoogleCodeExporter
Copy link
Author 

OK it's starting to look like fixing Issue 553 properly is more compelling.  
Earlier we were thinking it was simply that we were missing out on 
optimizations.  But breaking pages is not great.

One thing we can do with our current infrastructure is defer all scripts prior 
to the IE directive until the IE directive.  Then start again after the IE 
directive.  That way we preserve overall order.

I'm CCing Kishore so he is conscious of this but I think we should solve Issue 
553 first.

Original comment by jmara...@google.com on 8 Jan 2013 at 1:31

@GoogleCodeExporter
Copy link
Author

Original comment by jmara...@google.com on 14 Jan 2013 at 7:43

  • Changed state: Accepted

@GoogleCodeExporter GoogleCodeExporter mentioned this issue Apr 6, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
auto-migrated Priority-Medium Type-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter