Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Create a per VHOST specific error handler - Mod_Pagespeed_Errors #500

Open
GoogleCodeExporter opened this issue Apr 6, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

Create an enablable feature for logging Pagsepeed errors which will become 
available within a mod_pagespeed_errors handler. It would be nice to be given a 
VHOST filter if this handler becomes shared.
Some configurable memory buffer size to allow for configurability.

A secondary throttle feature to limit noisy VHOSTs might be nice.


Original issue reported on code.google.com by hayes...@gmail.com on 18 Sep 2012 at 7:37

@GoogleCodeExporter
Copy link
Author

Original comment by jmara...@google.com on 19 Sep 2012 at 12:33

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

I think the fix here is for the message_handler that we pass throughout the 
code to be vhost specific, or ideally completely per-request.

In nginx you can normally set an error_log at any scope including per-location, 
and this lets you specify both what file to log to and how verbose that log 
should be: http://nginx.org/en/docs/ngx_core_module.html#error_log

In apache it's the same, but the only scopes allowed for it are "server config, 
virtual host" which means it's not per-request 
http://httpd.apache.org/docs/current/mod/core.html#errorlog  Log-level *is* 
per-request, though: http://httpd.apache.org/docs/current/mod/core.html#loglevel

This is a big change, though: we talk to the message_handler through the 
factory in tons of places, and they'd all need to switch to getting it through 
the server context or request context.

On the other hand, if we're not going to do this we might as well just rip out 
all the uses of message_handler and use the LOG macros instead, because they 
offer the same level of logging control as a per-factory message handler with 
much cleaner code.

Original comment by jefftk@google.com on 23 Jun 2014 at 5:53

@GoogleCodeExporter
Copy link
Author

Issue 999 has been merged into this issue.

Original comment by jefftk@google.com on 6 Nov 2014 at 3:25

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant