Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Output CSS parsing errors in DebugMode() #479

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 2 comments
Closed

Output CSS parsing errors in DebugMode() #479

GoogleCodeExporter opened this issue Apr 6, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

We have a debug filter which, when enabled, triggers inserting of debug 
comments in the DOM. This could be used with CssFilter to add parse errors in 
DebugMode().

Original issue reported on code.google.com by sligocki@google.com on 26 Jul 2012 at 2:49

@GoogleCodeExporter
Copy link
Author

Specifically, we want to be able to type http://site?ModPagespeedFilters=+debug 
to give you HTML with comment annotations indicating why the system made 
various decisions.

As a Proof Of Concept that was already done for combine_css.  So we already 
have a filter called "debug", a query-param mechanism to incrementally add a 
new filter by name, and an API to insert a comment near the current event while 
calling filters.

We just need to put more of this information into more filters.

One complexity with the CSS parser is that it is currently calling LOG(X) 
directly rather than going through something like our MessageHandler API where 
we can capture the results.  We'd need to refactor that in a way that would 
continue to work for the non-instaweb google3 users of the CSS parser.

Original comment by jmara...@google.com on 28 Sep 2012 at 9:20

@GoogleCodeExporter
Copy link
Author

More can always be done, but this is much improved as of 1.9.

Original comment by jmara...@google.com on 18 Sep 2014 at 6:27

  • Changed state: Fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant