My favorites | Sign in
Project Home Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 405: ModPagespeedLoadFromFile doesn't set the Content-Type correctly when query params exist
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  sligocki@google.com
Closed:  Mar 2012


Sign in to add a comment
 
Reported by amat...@gmail.com, Mar 29, 2012
In r1231 (ref  issue 357 ), ModPagespeedLoadFromFile started stripping query params from the resource name before loading it. However, it seems that the query string params are still affecting the output in that they aren't stripped before determining the content type of certain resources. I'm seeing a lot of these in my log:


[Thu Mar 29 13:45:03 2012] [error] [mod_pagespeed 0.10.21.2-1381 @6876] Loaded resource with no Content-Type http://mysite.com/wp-includes/js/thickbox/thickbox.css?ver=20111117


It causes problems because that rewritten stylesheet is then served with a text/plain Content-Type header, effectively rendering it useless the first time it's served. Subsequent requests to that same resource load the mod_pagespeed- processed and cached resource, which then has the correct content type. Removing the ModPagespeedLoadFromFile directive and making mod_pagespeed fetch the file over HTTP resolves that issue.

The fix is to strip query params from the file name before determining the content type that's served for the not-yet-processed resource in the initial hit.
Mar 30, 2012
#1 amat...@gmail.com
To clarify, I believe this is only a problem when the rewrite deadline is exceeded. That can happen, for example, when a CSS file contains a ton of images in it and mod_pagespeed has to process / inline them all. If the CSS is processed within that deadline, it seems the correct content type is returned in spite of the logged error.
Mar 30, 2012
Project Member #2 sligocki@google.com
Aha, I can see how this is a problem.

When loading from file, we can only guess the file type based upon the extension and we are not correctly ignoring the query for this situation.

Looks easy to fix. I'm working on it now.

Thanks for the report.
Status: Accepted
Owner: sligocki@google.com
Mar 30, 2012
Project Member #3 sligocki@google.com
This issue was closed by revision r1494.
Status: Fixed
Mar 30, 2012
Project Member #4 sligocki@google.com
(No comment was entered for this change.)
Labels: release-note
May 22, 2012
Project Member #5 jmara...@google.com
(No comment was entered for this change.)
Labels: Milestone-v22
Sign in to add a comment

Powered by Google Project Hosting