Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

combine_css needs to strip BOM markers before combining #338

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 5 comments
Closed

combine_css needs to strip BOM markers before combining #338

GoogleCodeExporter opened this issue Apr 6, 2015 · 5 comments
Labels
auto-migrated Priority-Medium release-note Type-Defect

Comments

@GoogleCodeExporter
Copy link 

See:

http://www.w3.org/TR/css3-syntax/
http://www.w3.org/International/tutorials/tutorial-char-enc/#bom

Original issue reported on code.google.com by jmara...@google.com on 30 Aug 2011 at 9:48
@GoogleCodeExporter
Copy link
Author

Original comment by nfor...@google.com on 18 Oct 2011 at 2:14

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author 

I was not able to verify this fix, i have two CSS files with a BOM and when 
combine_css runs, it combines them and keeps the BOM.  Is there a changeset or 
revision number I can take a look at?

Original comment by iwokadzi...@gmail.com on 19 Dec 2011 at 7:17

@GoogleCodeExporter
Copy link
Author 

This bug was not properly fixed at time time we marked it as such last month, 
but we believe it's fixed in trunk now, as of this revision:  
http://code.google.com/p/modpagespeed/source/detail?r=1276

Original comment by jmara...@google.com on 19 Dec 2011 at 7:25

@GoogleCodeExporter
Copy link
Author 

Yeah, this got broken in a later revision.
You need parts of r1272 and of r1276 to re-fix it.

Original comment by morlov...@google.com on 19 Dec 2011 at 7:25

@GoogleCodeExporter
Copy link
Author

Original comment by matterb...@google.com on 26 Jan 2012 at 3:16

  • Added labels: release-note

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
auto-migrated Priority-Medium release-note Type-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter