Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Don't bundle libraries (at least optionally) #226

Open
GoogleCodeExporter opened this issue Apr 6, 2015 · 11 comments
Open

Don't bundle libraries (at least optionally) #226

GoogleCodeExporter opened this issue Apr 6, 2015 · 11 comments

Comments

@GoogleCodeExporter
Copy link

Bundled libraries are a generally bad idea from maintenance and security 
perspectives, and many distros will not include packages that include bundled 
libraries (packagers will de-bundle the libraries if they have to).

It would make the lives of package maintainers far easier if mod_pagespeed 
would at least optionally not bundle libraries (such as libpng, zlib, etc) and 
instead use system-provided copies.

Original issue reported on code.google.com by candrews...@gmail.com on 4 Mar 2011 at 5:00

@GoogleCodeExporter
Copy link
Author

Original comment by jmara...@google.com on 4 Mar 2011 at 5:51

  • Added labels: Type-Enhancement
  • Removed labels: Type-Defect

@GoogleCodeExporter
Copy link
Author

Note that you can make things a bit closer to what you want by using a slightly 
different build sequence:
gclient update -n
cd src
build/gyp_chromium -D use_system_libs=1
This will still checkout a whole bunch of libs, but most of them will not get 
linked in (though it will still link-in giflib as of this moment, 
unfortunately). As a bit of a downside, however, using system version of 
opencv's libhighgui (which we use for I/O routines, not UI) does pull in gtk, 
which isn't a very server'ish dependency at all.


Original comment by morlov...@google.com on 25 Apr 2011 at 5:09

@GoogleCodeExporter
Copy link
Author

Original comment by jmara...@google.com on 6 May 2011 at 3:07

@GoogleCodeExporter
Copy link
Author

YEAH, I was looking into making this apache module available for the openSUSE 
distribution but all the non-standard build system and the bundled libraries 
make unlikely that I will devout any resources to it.

An standalone tarball with no bundled libraries and a text file that says, "we 
need libraries X , Y, Z version N or later.." and a simple Makefile or 
configure script is enough for distributions, we can figure out the rest by 
ourselves.

Original comment by judas.iscariote on 11 May 2011 at 7:26

@GoogleCodeExporter
Copy link
Author

Same for Gentoo Linux.
The attempt to create an ebuild is 'sleeping' because the bundled libraries and 
the gclient/svn logic.
A standalone tarball, as judas said - better if released with a version 
tag/number - and deps indications could be helpful.

Original comment by sergiova...@gmail.com on 11 May 2011 at 11:28

@GoogleCodeExporter
Copy link
Author

I've been working on this, and I am at a point where we're almost down to just 
google dependencies being bundled (fixing icu and giflib being included is the 
next step); and I would appreciate if you could perhaps take a look at the 
intermediate step to see if it's moving in the right direction. I am attaching 
a script for tarball generation --- I imagine we will eventually provide the 
sort of tarballs it produces as part of releases.

To use it just do something like:
"./create_distro_tarball.sh modpagespeed.tar.bz2 --svn_path tags/0.9.17.6". It 
will checkout tons of stuff (and throw most of it away) and should eventually 
produce a tarball that's more like the usual expectations. (The tarball will be 
in the /tmp/ directory it gives at the end).

Original comment by morlov...@google.com on 18 May 2011 at 3:33

Attachments:

@GoogleCodeExporter
Copy link
Author

that's a progress :) I currently checking it out, I just want to make a plea to 
google to understand that "the google way" of distributing source code is 
unnaceptable to probably all the distributions.

Im not asking to change your process, just try to be a little more friendly so 
your software can get included. some hints, having:

a) lots of bundled libraries including your owns.
b) a weird, pretty much undocumented,non-standard build system
c) the need of forked libraries

Will certainly discorauge packagers, fundamentally because that is either too 
much work to maintain or the effort of doing so will be worthless as the QA 
teams of the respective distribution will reject such stuff almost instantly.


Original comment by judas.iscariote on 26 May 2011 at 6:23

@GoogleCodeExporter
Copy link
Author

Original comment by jmara...@google.com on 26 May 2011 at 6:30

@GoogleCodeExporter
Copy link
Author

Hey there, I was curious if there has been any progress on this.  We have an 
environment with non standard Apache paths.  Rolling the current build process 
into an RPM is a bit of a caper.  Thanks!

Original comment by brickgee...@gmail.com on 16 Dec 2011 at 10:01

@GoogleCodeExporter
Copy link
Author

Original comment by jmara...@google.com on 24 May 2012 at 7:25

  • Changed state: Accepted

@janreges
Copy link

Hi, is there any plan to fix this issue?

It blocks also implementation of PageSpeed into Gentoo, see https://bugs.gentoo.org/661482

Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants