My favorites | Sign in
Project Logo
                
New issue | Search
for
| Advanced search | Search tips
Issue 17: The plugin make Pidgin crash if there is no internet connection
2 people starred this issue and may be notified of changes. Back to list
Status:  Verified
Owner:  chanwit
Closed:  Aug 2008
Type-Defect
Priority-High


Sign in to add a comment
 
Reported by chanwit, Aug 02, 2008
Step to reproduce:

1. open Pidgin with libtwitter
2. disconnect the internet
3. wait until libtwitter trying to query a new update
4. Pidgin crashed.

Environment is Windows XP, Pidgin 2.4.3.

Comment 1 by somsaks, Aug 05, 2008
Ok, I'll look into this.
Status: Accepted
Comment 2 by somsaks, Aug 05, 2008
Could you try again with latest code committed (r80 of twitter.c)? It doesn't
happened again on my laptop. Although I only fix few things here.

BTW, there's potential memory leak in twitterim_close function. TwitterProxyData is
not being freed up if connection closed. I'll fix that soon.
Comment 3 by chanwit, Aug 05, 2008
It's still crashing. What I've tried this time is to start Pidgin without connecting
the internet. Pidgin died during startup after "twitter: closing all active
connection". Please see the log below. 

(20:04:28) twitter: twitterim_process_request
(20:04:28) twitter: connecting to twitter.com on port 443
(20:04:28) dnsquery: Performing DNS lookup for twitter.com
(20:04:28) twitter: after connect
(20:04:28) twitter: connect (seems to) success
(20:04:28) account: Connecting to account chanwit@gmail.com
(20:04:28) connection: Connecting. gc = 01C5DA98
(20:04:28) msn: new httpconn (01C5DB58)
(20:04:28) dnsquery: Performing DNS lookup for messenger.hotmail.com
(20:04:28) dnsquery: Error resolving messenger.hotmail.com: 11004
(20:04:28) proxy: Connection attempt failed: Error resolving messenger.hotmail.com: 11004
(20:04:28) msn: Connection error: Error resolving messenger.hotmail.com: 11004
(20:04:28) msn: Connection error from Notification server (messenger.hotmail.com):
Unable to connect
(20:04:28) account: Disconnecting account 00C9F1C0
(20:04:28) connection: Disconnecting connection 01C5DA98
(20:04:28) msn: destroy httpconn (01C5DB58)
(20:04:28) connection: Destroying connection 01C5DA98
(20:04:30) dnsquery: Error resolving twitter.com: 11001
(20:04:30) proxy: Connection attempt failed: Error resolving twitter.com: 11001
(20:04:30) account: Disconnecting account 003EC138
(20:04:30) connection: Disconnecting connection 01C4F8A0
(20:04:30) twitter: twitterim_close
(20:04:30) twitter: closing all active connection

Comment 4 by somsaks, Aug 06, 2008
Ok, code in SVN fixed. Please try again.
Comment 5 by chanwit, Aug 07, 2008
Tested with r86, it has not crashed this time but:
1. When disconnecting net, Pidgin is frozen, and CPU is eaten up to 50%.
2. When starting Pidgin (-d), it's crashed with GLib mem.c saying that it's could not
allocate memory for 86 bytes.
Comment 6 by somsaks, Aug 13, 2008
The issue is fixed!

I believe this should be the correct place. 

The culprit is hash table id, the file descriptor is never set by Purple and it's
always -1, so the last hash_table_destroy loop trying to free already freed memory.
Comment 7 by chanwit, Aug 14, 2008
Hi, i think this bug is still around.
My pidgin is still crashed in this situation:

1. disconnect net.
2. start Pidgin.
3. it will say "SSL Error" for the twitter account, and let your press the little
"re-connect" button.
4. after pressing the "re-connect" button, Pidgin died.

Comment 8 by somsaks, Aug 16, 2008
Fixed in SVN.

It's in branch 0.1.1.

https://microblog-purple.googlecode.com/svn/branches/0.1.1

The problem occurred because I'm not properly handle SSL error. Caller of SSL error
function will close SSL connection once it's finished. 


Comment 9 by chanwit, Aug 16, 2008
(No comment was entered for this change.)
Status: Verified
Comment 10 by locke.db, Sep 04, 2009
Still exists in 0.2.2. Crashes Pidgin on "re-connect".

Ubuntu Karmic x86_64 on Pidgin 2.6.1.
Sign in to add a comment

Hosted by Google Code