Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPTC character encoding #39

Closed
wants to merge 1 commit into from

Conversation

RicardoBochnia
Copy link
Contributor

#12

Works also with given images from the google code issue. Although the encoding-undefined-iso.jpg is an example of bad practice.

The iptc CodedCharacterSet tag will be used for the encoding of iptc
tags. If not available the IptcReader will try to guess the encoding.
@drewnoakes
Copy link
Owner

This looks great. I'll run some tests when back from a conference this weekend, but I can't see any issues with this. It will make some people really happy, that's for sure.

@drewnoakes
Copy link
Owner

Finally taking a look at this. Seems to work really well on the image database. Nice one!

@drewnoakes
Copy link
Owner

Thanks. Also pushed to master. Would be nice to hear the story about the case in IptcReader when you have a chance.

@drewnoakes drewnoakes closed this Dec 4, 2014
@drewnoakes drewnoakes added this to the 2.7.0 milestone Dec 4, 2014
@RicardoBochnia
Copy link
Contributor Author

Try the images from the google code issue.

@drewnoakes drewnoakes changed the title 12 IPTC character encoding IPTC character encoding Dec 5, 2014
@drewnoakes
Copy link
Owner

@Odrahcyr, ok I see. I added some unit tests that operate on the data from those images and now a breakpoint in that case gets hit when debugging the unit tests. I think it can be folded into the TAG_APPLICATION_RECORD_VERSION case, so will try that now.

drewnoakes added a commit that referenced this pull request Dec 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants