Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect torrent and download path generating invalid torrents. #632

Closed
psouza4 opened this issue Jul 24, 2015 · 8 comments
Closed

Incorrect torrent and download path generating invalid torrents. #632

psouza4 opened this issue Jul 24, 2015 · 8 comments
Assignees
Labels

Comments

@psouza4
Copy link
Owner

psouza4 commented Jul 24, 2015

Originally reported on Google Code with ID 632

During the normal new episode get MCM found torrent URL's but then applied them to incorrect
domain paths

7:42 PM :: MCM:  Keeping series up to date...
7:42 PM :: MCM:  Downloading new and missing episodes for Glee
7:42 PM :: MCM:  ... search term: "glee"
7:42 PM :: EZTV.it:  Searching for "glee S02E19"
7:42 PM :: EZTV.it:  Results list fetched, looking for the best torrent...
7:43 PM :: MCM:  http://torrent.zoink.it/Glee.S02E19.720p.HDTV.X264-DIMENSION.[eztv].torrent
7:43 PM :: MCM:  http://torrents.thepiratebay.org/6365446/Glee_S02E19_720p_HDTV_X264-DIMENSION.6365446.TPB.torrent
7:43 PM :: MCM:  http://torrage.com/torrent/94D9FA99807998196A29B8CF3302748431937EA0.torrent
7:43 PM :: EZTV.it:  I found one I'm happy with, downloading the torrent file...
7:43 PM :: EZTV.it:  ... Glee S02E19 720p HDTV X264-DIMENSION (from: eztv.it)
7:43 PM :: EZTV.it:  ... http://zoink.it/torrent/94D9FA99807998196A29B8CF3302748431937EA0.torrent
7:43 PM :: EZTV.it:  Done and saved the torrent file.
7:43 PM :: MCM:  done!

One issue is that 720+ torrents are not enabled in settings.  Second most important
issue is the torrage.com hash torrent file name has been incorrectly applied to a different
domain name of zonink.it.  Thus resulting in a non valid file being download/created
by MCM


version of MCM running:
Installation name: Media Center Master v1.28
Installation date: 20110108
Media Center Master: 1.30.11711.977

Reported by rumbaar on 2011-05-04 09:50:54

@psouza4
Copy link
Owner Author

psouza4 commented Jul 24, 2015

Happened again with a different series

2:58 PM :: MCM:  Keeping series up to date...
2:58 PM :: MCM:  Downloading new and missing episodes for Camelot
2:58 PM :: MCM:  ... search term: "camelot"
2:58 PM :: EZTV.it:  Searching for "camelot S01E06"
2:58 PM :: EZTV.it:  Results list fetched, looking for the best torrent...
2:58 PM :: MCM:  Detected quality of a high-def episode (torrent size), want HD = False,
title = Camelot S01E06 HDTV XviD-SYS
2:58 PM :: MCM:  http://torrent.zoink.it/Camelot.S01E06.HDTV.XviD-SYS.[eztv].torrent
2:58 PM :: MCM:  Detected quality of a high-def episode (torrent size), want HD = False,
title = Camelot S01E06 HDTV XviD-SYS
2:58 PM :: MCM:  http://torrents.thepiratebay.org/6372966/Camelot_S01E06_HDTV_XviD-SYS.6372966.TPB.torrent
2:58 PM :: MCM:  Detected quality of a high-def episode (torrent size), want HD = False,
title = Camelot S01E06 HDTV XviD-SYS
2:58 PM :: MCM:  http://torrage.com/torrent/DB5884B88F8453B32F35A776C5ECFE5914A1FFE1.torrent
2:58 PM :: EZTV.it:  I found one I'm happy with, downloading the torrent file...
2:58 PM :: EZTV.it:  ... Camelot S01E06 HDTV XviD-SYS (from: eztv.it)
2:58 PM :: EZTV.it:  ... http://zoink.it/torrent/DB5884B88F8453B32F35A776C5ECFE5914A1FFE1.torrent
2:58 PM :: EZTV.it:  Done and saved the torrent file.
2:58 PM :: MCM:  done!

Which resulting in an invalid torrent file called "camelot S01E06 [TV Episode].torrent"

Reported by rumbaar on 2011-05-07 05:27:20

@psouza4 psouza4 self-assigned this Jul 24, 2015
@psouza4
Copy link
Owner Author

psouza4 commented Jul 24, 2015

The saved file names/paths are intentional and the 'hash' are correct as well.

The real problem you are seeing is with zoink.it and torrage.com.  Those sites are
both sending gzip-compressed content, but the webservers aren't correctly tagging it
as compressed so the resulting file is a gzip-version and thus not a valid torrent
file.  Recent changes have attempted to fix this and analyze the data (which has worked
for some people).

Please check the forums for keyword 'torrage.com'.

Reported by psouza4 on 2011-05-07 16:15:32

  • Status changed: CantVerify

@psouza4
Copy link
Owner Author

psouza4 commented Jul 24, 2015

I was under the impression that torrage.com was the only one using a gzip compression
as it had been the only site causing the issue in the past.  What do you think is causing
the generation of the torrent file with the text [TV Episode] in it?

Reported by rumbaar on 2011-05-09 07:32:20

@psouza4
Copy link
Owner Author

psouza4 commented Jul 24, 2015

>> I was under the impression that torrage.com was the only one using a gzip compression
as it had been the only site causing the issue in the past.

Neither of those are true.  In fact, many use gzip -- but a few websites are using
it without properly including the HTML header to indicate it, which is a violation
of W3C standards and is the source of the problem.

You may mean to say that only torrage.com is doing this improperly, but that's not
even true.  torrage.com and zoink.it are owned by the same operating group and the
IP addresses for their websites are on the same class C (192.121.86.94 vs. 192.121.86.89).



>> What do you think is causing the generation of the torrent file with the text [TV
Episode] in it?

Media Center Master is.  By design.

I wrote it to create torrent filenames that are named in that way for better collision
avoidance and in case some site names their torrent something obscure.  A great example
is zoink.it and torrage.com.  With a huge hash filename, if the torrent can't load,
you'd have no idea what it is.

------------------------------------------------------------

What is really the bottom line problem is torrage.com and zoink.it (and possibly others)
are hosting .torrents that they send to a browser in gzip but forget to tell the browser
they're compressing it.  The last auto-update build in MCM tried to handle this by
doing some automatic gzip detection and decompression, which worked for me using some
torrage.com test links, but apparently hasn't worked for everyone, so I'm currently
in the process of revisiting this.  It's not a simple process and there's no simple
answer.

The easiest work around at this time is to avoid those two hosts (you can block them
out in your HOSTS. file).  Of the torrent sites that MCM uses, I think only eztv.it
links to those two hosts, so you could also just remove eztv.it as one of your sources
in MCM.

I realize what a pain this is; I am working towards a solution that will work around
the issues with those sites, although in reality it'd be a better solution for those
sites to fix their webserver.

Reported by psouza4 on 2011-05-09 13:32:37

@psouza4
Copy link
Owner Author

psouza4 commented Jul 24, 2015

Thank you for the continued revisiting of this issue, and I don't profess to fully understand
the gzip and incorrect headers issue but I know it's an issue of incorrect site designers
I'm sure.  Which is a shame.

What I don't get is that, for example eztv.it has the link as:
http://torrent.zoink.it/Camelot.S01E06.HDTV.XviD-SYS.[eztv].torrent

Than MCM takes that plain text title [Camelot.S01E06.HDTV.XviD-SYS.[eztv].torrent]
and turns it into DB5884B88F8453B32F35A776C5ECFE5914A1FFE1.torrent

Then applies it to the subfolder instead of the subdomain http://torrent.zoink.it/
-> http://zoink.it/torrent/

Then results in a MCM converted torrent name of "camelot S01E06 [TV Episode].torrent"?

So if MCM just hit the original URL it wouldn't result in a valid torrent file due
to this gzip issue?

I know I can block those sites at the HOSTS level and/or remove eztv.it, but it's the
only one that is guaranteed to be a non fake torrent from the list of those that are
available to me via MCM.

Reported by rumbaar on 2011-05-09 22:00:45

@psouza4
Copy link
Owner Author

psouza4 commented Jul 24, 2015

Not sure if you still monitor or get notifications of bugs you've deemed 'cantverify'
but here are some additional logs with DEBUG enabled.  It seems to be an issue with
the incorrect detection of HD content

6:28 PM :: EZTV.it:  Searching for "camelot S01E08"
6:28 PM :: [18:28:22.087] DEBUG:  EZTV.it:  http://eztv.it/shows/469/camelot/
6:28 PM :: EZTV.it:  Results list fetched, looking for the best torrent...
6:28 PM :: [18:28:22.697] DEBUG:  Comparing Camelot S01E08 720p HDTV X264-DIMENSION
to 01E08
6:28 PM :: [18:28:22.777] DEBUG:  URL: http://torrent.zoink.it/Camelot.S01E08.720p.HDTV.X264-DIMENSION.[eztv].torrent
6:28 PM :: [18:28:31.159] DEBUG:  File: Camelot.S01E08.720p.HDTV.X264-DIMENSION.mkv
6:28 PM :: [18:28:31.299] DEBUG:  Detected quality of a high-def torrent (MKV detected),
want HD = False, title = Camelot S01E08 720p HDTV X264-DIMENSION
6:28 PM :: MCM:  http://torrent.zoink.it/Camelot.S01E08.720p.HDTV.X264-DIMENSION.[eztv].torrent
6:28 PM :: [18:28:31.449] DEBUG:  URL: http://torrents.thepiratebay.org/6410884/Camelot_S01E08_720p_HDTV_X264-DIMENSION.6410884.TPB.torrent
6:28 PM :: [18:28:36.739] DEBUG:  File: Camelot.S01E08.720p.HDTV.X264-DIMENSION.mkv
6:28 PM :: [18:28:36.819] DEBUG:  Detected quality of a high-def torrent (MKV detected),
want HD = False, title = Camelot S01E08 720p HDTV X264-DIMENSION
6:28 PM :: MCM:  http://torrents.thepiratebay.org/6410884/Camelot_S01E08_720p_HDTV_X264-DIMENSION.6410884.TPB.torrent
6:28 PM :: [18:28:36.979] DEBUG:  Skipped http://www.kat.ph/torrents/camelot-s01e08-720p-hdtv-x264-dimension-t5505764/
because it didn't end in ".torrent"
6:28 PM :: [18:28:37.109] DEBUG:  Skipped http://www.bt-chat.com/download1.php?id=124739
because it didn't end in ".torrent"
6:28 PM :: [18:28:37.209] DEBUG:  URL: http://torrage.com/torrent/2686B88F77EC7876BF6779687CF97545BE9D5A00.torrent
6:28 PM :: [18:28:42.169] DEBUG:  File: Camelot.S01E08.720p.HDTV.X264-DIMENSION.mkv
6:28 PM :: [18:28:42.249] DEBUG:  Detected quality of a high-def torrent (MKV detected),
want HD = False, title = Camelot S01E08 720p HDTV X264-DIMENSION
6:28 PM :: MCM:  http://torrage.com/torrent/2686B88F77EC7876BF6779687CF97545BE9D5A00.torrent
6:28 PM :: [18:28:42.419] DEBUG:  URL: http://zoink.it/torrent/2686B88F77EC7876BF6779687CF97545BE9D5A00.torrent
6:28 PM :: EZTV.it:  I found one I'm happy with, downloading the torrent file...
6:28 PM :: EZTV.it:  ... Camelot S01E08 720p HDTV X264-DIMENSION (from: eztv.it)
6:28 PM :: EZTV.it:  ... http://zoink.it/torrent/2686B88F77EC7876BF6779687CF97545BE9D5A00.torrent
6:28 PM :: EZTV.it:  Done and saved the torrent file.

This too resulted in an invalid file named "camelot S01E08 [TV Episode].torrent"  The
hash used here is for the HD file name.

I haven't had a successfully torrent fetch with the DEBUG setting on but this is an
example of the successfully fetch URL and torrent title I get from that same target
source URL

12:12 PM :: MCM:  ... search term: "big bang theory"
12:12 PM :: EZTV.it:  Searching for "big bang theory S04E24"
12:12 PM :: EZTV.it:  Results list fetched, looking for the best torrent...
12:12 PM :: EZTV.it:  I found one I'm happy with, downloading the torrent file...
12:12 PM :: EZTV.it:  ... The Big Bang Theory S04E24 The Roomate Transmogrification
HDTV XviD-FQM (from: eztv.it)
12:12 PM :: EZTV.it:  ... http://torrent.zoink.it/The.Big.Bang.Theory.S04E24.The.Roomate.Transmogrification.HDTV.XviD-FQM.[eztv].torrent
12:12 PM :: EZTV.it:  Done and saved the torrent file.


Reported by rumbaar on 2011-05-21 23:45:10

@psouza4
Copy link
Owner Author

psouza4 commented Jul 24, 2015

Hi -- I don't think you understand me.

It is 100% intentional that Media Center Master is changing the filename!  MCM doesn't
care what the filename is from the URL, it creates its own filename by downloading
the contents and naming the file something more meaningful.  I keep telling you this,
but I don't know how to make it any clearer -- sorry.

Reported by psouza4 on 2011-05-22 01:07:09

@psouza4
Copy link
Owner Author

psouza4 commented Jul 24, 2015

Okay lets ignore the end file name for now.

In the first section of logs in the last post I made they were all HD 720 torrents
and should, at the very least, resulted in zero torrents MCM should have been 'happy
with'.  But it did find one and download said torrent, which was invalid.  They are
always, from memory, 46kb in size.  Would making one available be of any help?

Now in the second log a positive hit on the same URL [sort of] of torrent.zoink.it
from eztv.it results in a torrent named "The.Big.Bang.Theory.S04E24.The.Roomate.Transmogrification.HDTV.XviD-FQM.avi.torrent"


Without a 'torrage.com' source URL in the list of URL's MCM finds for that torrent
it doesn't seem to feel the need to hash it and/or create a resulting torrent named
different to the original.

From what I can tell there is only an issue with HD torrents and/or combination of
sources that include torrage.com in the array MCM finds.

Reported by rumbaar on 2011-05-22 05:16:11

@psouza4 psouza4 closed this as completed Jul 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant