Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch] Update to Eclipse 3.7.1 Service Release 1 #18

Closed
GoogleCodeExporter opened this issue Mar 14, 2015 · 8 comments
Closed

[patch] Update to Eclipse 3.7.1 Service Release 1 #18

GoogleCodeExporter opened this issue Mar 14, 2015 · 8 comments
Assignees
@mblanchette
Labels
auto-migrated enhancement
Milestone
0.4

Comments

@GoogleCodeExporter
Copy link
Contributor 

Version 0.4-SNAPSHOT (as of rev 117) uses Eclipse 3.3. This causes difficulty 
for people wanting to achieve identical code formatting results in newer 
Eclipse versions and using the plugin.

I have forked maven-java-formatter-plugin at 
https://github.com/benalexau/maven-java-formatter-plugin/ and made the 
following three changes:

1. I have obtained from an Eclipse 3.7.1 SR 1 download all Eclipse JARs used by 
maven-java-formatter-plugin and updated their POMs. These are published in the 
above GitHub repository.

2. The pom.xml has been amended to refer to the new versions.

3. The FormatterMojo was modified to use CodeFormatter.K_COMPILATION_UNIT + 
CodeFormatter.F_INCLUDE_COMMENTS.

This tested fine both via the unit tests and in practical testing against 
actual code. Importantly, the same formatting results were available from 
within the IDE and via the plugin.

While I have published the GitHub fork in a manner that enables end users to 
use the plugin immediately, I would greatly prefer this update was folded into 
the official project and I can take down the forked copy. I put it up to prove 
it worked, and to provide an immediate solution to my own project's needs.

If you have any questions/queries please don't hesitate.

Thanks for taking the time to share this very useful plugin.

Original issue reported on code.google.com by ben.a...@acegi.com.au on 18 Dec 2011 at 5:19
@GoogleCodeExporter
Copy link
Contributor Author 

Great work.
I'll need to find an equivalent for these libraries in Maven central if 
possibly, so far what I've found is:

<dependency>
<groupId>org.eclipse.tycho</groupId>
<artifactId>org.eclipse.jdt.core</artifactId>
<version>3.8.1.v20111205-1355</version>
</dependency>
<!-- There is also beta version 3.7.0.v_B61 -->

<dependency>
<groupId>org.eclipse.core</groupId>
<artifactId>org.eclipse.core.runtime</artifactId>
<version>3.6.0.v20100505</version>
</dependency>
<!-- This version now strictly depends on the following:
org.eclipse.core    org.eclipse.core.contenttype    3.4.100.v20100505-1235
org.eclipse.core    org.eclipse.core.runtime.compatibility.auth     3.2.200.v20100517
org.eclipse.equinox     org.eclipse.equinox.app     1.3.0.v20100512
These are included but commented out in the pom:
org.eclipse.core    org.eclipse.core.jobs   3.5.0.v20100515
org.eclipse.equinox     org.eclipse.equinox.common  3.6.0.v20100503
org.eclipse.equinox     org.eclipse.equinox.preferences     3.3.0.v20100503
org.eclipse.equinox     org.eclipse.equinox.registry    3.5.0.v20100503
org.eclipse.osgi    org.eclipse.osgi    3.6.0.v20100517
This this version no longer includes version ranges, it removed some of the 
need for the dependency management section
-->

<dependency>
  <groupId>org.jibx.config.3rdparty.org.eclipse</groupId>
  <artifactId>org.eclipse.text</artifactId>
  <version>3.5.100.v20110505-0800</version>
</dependency>
<!-- I didn't see any official newer version of this artifact, but this 3rd 
party upload also includes most, without their dependency relationships in the 
poms -->
http://repo1.maven.org/maven2/org/jibx/config/3rdparty/org/eclipse/

Original comment by xbb...@gmail.com on 7 Jan 2012 at 2:34

@GoogleCodeExporter
Copy link
Contributor Author 

I have managed to get the Eclipse 3.7.1 fork running using the 
org.eclipse.tycho and org.jibx.config.3rdparty.org.eclipse libraries.
See the attached pom file for the changes (marked with comments)
I have also 'removed' the dependencies which appear to be unused.

Original comment by Mark.van...@inology.nl on 24 Apr 2012 at 9:22

Attachments:

@GoogleCodeExporter
Copy link
Contributor Author 

Hi Ben

Following issue is still not fixed with your plugin branch.
Issue 16:Maven formatter plugin doesnt produce formatting as per the 
configuration

As given in the issue ,if i specify the maximum length of a line as 100 
characters in the config file,formatter plugin is not able to limit the length 
of line containing generic parameters to 100.Can you please let me know what i 
can change to resolve this issue.
Thanks
Amit

Original comment by amitverm...@gmail.com on 11 May 2012 at 4:15

@GoogleCodeExporter
Copy link
Contributor Author 

Hi - it's been almost a year since Ben did his work on this. Could we perhaps 
get this pulled in?

Original comment by coop4...@gmail.com on 1 Dec 2012 at 6:34

@GoogleCodeExporter
Copy link
Contributor Author 

Commit updates to trunk pom in r118 and r119

Further testing needed to verify fixes of this and related issues

Original comment by matt.blanchette@gmail.com on 2 Dec 2012 at 7:50

  • Added labels: Milestone-0.4

@GoogleCodeExporter
Copy link
Contributor Author

Original comment by matt.blanchette@gmail.com on 2 Dec 2012 at 7:51

  • Changed state: Started

@GoogleCodeExporter
Copy link
Contributor Author 

would love a release of this fix. It's the only thing holding me back from 
using this maven plugin.

Original comment by elisedl...@gmail.com on 9 Apr 2013 at 11:58

@GoogleCodeExporter
Copy link
Contributor Author 

Release 0.4 is available in maven central

Original comment by matt.blanchette@gmail.com on 12 Aug 2013 at 11:49

  • Changed state: Fixed

@ctubbsii ctubbsii modified the milestone: 0.4 May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mblanchette mblanchette

Labels
auto-migrated enhancement
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
3 participants
@mblanchette @ctubbsii @GoogleCodeExporter