Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AMPs to include literals in version number (was: Git support) #65

Closed
mindthegab opened this issue Jul 20, 2014 · 11 comments
Closed

Comments

@mindthegab
Copy link
Contributor

From daniele....@gmail.com on February 08, 2012 10:31:37

What steps will reproduce the problem? 1. set up mavn scm git http://maven.apache.org/scm/git.html 2. being able to create amp with automatically increasing versions with each git commit 3. probably a configuration could be enough, I ask for help defining a configuration that will work

Original issue: http://code.google.com/p/maven-alfresco-archetypes/issues/detail?id=65

@mindthegab
Copy link
Contributor Author

From mauri...@session.it on April 04, 2012 13:13:59

Hi Daniele,
I'm happy you ask about git since I'm a big fan of it!
I've added a page where I go through the steps to configure an Alfresco AMP project with git - https://wiki.alfresco.com/wiki/Maven_For_Dummies#Using_Git You can also have a look at my github project - https://github.com/maoo/alfresco-amp-test I am eager to hear some feedback from you, so that I can improve this section and make it more complete.
Marking the issue as Enhancement

Labels: -Type-Defect Type-Enhancement

@mindthegab
Copy link
Contributor Author

From daniele....@gmail.com on April 05, 2012 02:01:24

Hi Maurizio,

I ended up setting it like this, in my parent pom (project with modules) I defined:

I've set up git like this:

<!-- Source Control Management -->
<scm>
    <connection>scm:git:git@my.private.gitolite.repo:my/project/id</connection>
    <developerConnection>scm:git:git@my.private.gitolite.repo:my/project/id</developerConnection>
    <url> https://my.webview.of.the.git.repos/projects/my-project-id/repository</url> </scm>

And my artifactory (for artifacts deployment on release) like this:

<!-- Artifact deployments -->
<distributionManagement>
    <repository>
        <id>central</id>
        <name>my.artifactory.server-releases</name>
        <url> http://my.artifactory.server/artifactory/libs-release-local</url> </repository>
    <snapshotRepository>
        <id>snapshot</id>
        <name>my.artifactory.server-snapshots</name>
        <url> http://my.artifactory.server/artifactory/libs-snapshot-local</url> </snapshotRepository>
</distributionManagement>

I did not set up the release plugin to run on its own, I'm the one executing it when I want it, actually I use Jenkins to execute it.

More or less that's what you did.

I wanted to make my amp version to increase in it's minor automatically with git commits, but I think that's no way to do it in a non-linear development environment like the one provided by git/mercurial.

so I changed the module.properties in my AMP project

from

module.version=${noSnapshotVersion}.${buildNumber}

to

module.version=${noSnapshotVersion}

I think this is actually better: alfresco doesn't support the downgrade of the modules and if I install the 1.0.0.7 I can't go back to the 1.0.0.6

This is very annoying if you jump from one branch to another :)

Conclusion: the actual fix should come from Alfresco that should support non-numeric versions and downgrading of the module (or at least an option to allow it in development mode).

@mindthegab
Copy link
Contributor Author

From mauri...@session.it on April 06, 2012 04:14:04

Added issue to Alfresco JIRA, please vote ;-) https://issues.alfresco.com/jira/browse/ENH-1232

@mindthegab
Copy link
Contributor Author

From daniele....@gmail.com on April 06, 2012 06:38:42

Hi Maurizio,

I can't vote the issue, when I click the link I get "Permission Violation"

@mindthegab
Copy link
Contributor Author

From carlo.sciolla on April 07, 2012 07:09:50

Yep, double check the security level for that issue, I bet only Alfresco hat holders can look into that.

@mindthegab
Copy link
Contributor Author

From mauri...@session.it on April 09, 2012 04:54:26

Not sure it should be the right behaviour. FWDed issue internally, will keep you posted!

@mindthegab
Copy link
Contributor Author

From colum...@gmail.com on October 29, 2012 15:54:33

Postponed to post 1.0.0 release of the Maven Alfresco SDK. Pushed internally to open up the ENH(ancemements) JIRA project.

Status: Accepted
Labels: Milestone-Release-sdk-1.0.1

@mindthegab
Copy link
Contributor Author

From colum...@gmail.com on February 14, 2013 02:15:54

Labels: -Milestone-Release-sdk-1.0.1 Milestone-Release-sdk-1.0.2

@mindthegab
Copy link
Contributor Author

From colum...@gmail.com on June 13, 2013 08:27:24

Labels: -Milestone-Release-sdk-1.0.2 Milestone-Release-sdk-unscheduled

@mindthegab
Copy link
Contributor Author

From maurizio...@alfresco.com on July 03, 2014 02:38:41

Summary: Allow AMPs to include literals in version number (was: Git support) (was: Git support)

@mindthegab
Copy link
Contributor Author

From maurizio...@alfresco.com on July 03, 2014 02:41:00

Status: Duplicate
Mergedinto: 69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant