Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task for creating DMG installation image #59

Merged
merged 2 commits into from Aug 23, 2015
Merged

Add task for creating DMG installation image #59

merged 2 commits into from Aug 23, 2015

Conversation

jirutka
Copy link
Contributor

@jirutka jirutka commented Jul 18, 2015

I was asked by @eirnym to send PR b4winckler/macvim#26 (that I’ve created 3 years ago) to this repository. I rewrote it to a make task, changed MacVim logo in a background image to your new shiny logo and redesigned the background a bit.

macvim

./configure
make macvim-dmg

@eirnym
Copy link
Contributor

eirnym commented Jul 21, 2015

I like this disk image, and it has some advantages over zip:

  • checksum checking over the bundle
  • easer to search over distributives.

@eirnym
Copy link
Contributor

eirnym commented Jul 21, 2015

@jirutka I prefer minimalistic background: bigger MacVim icon leads to confusion which icon I should drag into Applications folder. So if it'll be blurred enough and/or be background of "drag action", it will be better, really.

@jirutka
Copy link
Contributor Author

jirutka commented Jul 21, 2015

@eirnym Okay, I’ll wait for reaction from @douglasdrumond and then I’ll possibly redesing the background picture a bit. I don’t want to waste my time for the second time, just 3 years later. ;)

@eirnym
Copy link
Contributor

eirnym commented Jul 21, 2015

@jirutka I hope there's no problems with licences.

@jirutka
Copy link
Contributor Author

jirutka commented Jul 21, 2015

@eirnym What licences? I took logo from #1 and as I understand it, this is the “official” MacVim logo.

@eirnym
Copy link
Contributor

eirnym commented Jul 21, 2015

Tool you used is under MIT licence.

@jirutka
Copy link
Contributor Author

jirutka commented Jul 21, 2015

Ah, that one. MIT is very permissive license, so I hope that it’s not a problem. However, I’m not a lawyer.

douglasdrumond added a commit that referenced this pull request Aug 23, 2015
Add task for creating DMG installation image
@douglasdrumond douglasdrumond merged commit 9a7fc99 into macvim-dev:master Aug 23, 2015
@eirnym
Copy link
Contributor

eirnym commented Aug 24, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants