Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest commits broke build on Leopard #40

Closed
chdiza opened this issue May 29, 2015 · 3 comments
Closed

Latest commits broke build on Leopard #40

chdiza opened this issue May 29, 2015 · 3 comments

Comments

@chdiza
Copy link
Contributor

chdiza commented May 29, 2015

While building what has been tagged "Snapshot 76" works on Leopard, the last couple of commits since then have broken the build:

The following build commands failed:
MacVim:
    CompileC build/MacVim.build/Release/MacVim.build/Objects-normal/ppc/MMAppController.o /bld/kakvim/src/MacVim/MMAppController.m normal ppc objective-c com.apple.compilers.gcc.4_0
    CompileC build/MacVim.build/Release/MacVim.build/Objects-normal/ppc/MMVimController.o /bld/kakvim/src/MacVim/MMVimController.m normal ppc objective-c com.apple.compilers.gcc.4_0
(2 failures)

Looking back in the build output, this is the only thing that looks relevant:

CompileC build/MacVim.build/Release/MacVim.build/Objects-normal/ppc/MMAppController.o /bld/kakvim/src/MacVim/MMAppController.m normal ppc objective-c com.apple.compilers.gcc.4_0
    cd /bld/kakvim/src/MacVim
    /Developer/usr/bin/gcc-4.0 -x objective-c -arch ppc -fmessage-length=0 -pipe -Wno-trigraphs -fpascal-strings -Os -mdynamic-no-pic -Wreturn-type -Wunused-variable -mtune=G5 -fvisibility=hidden -I/bld/kakvim/src/MacVim/build/MacVim.build/Release/MacVim.build/MacVim.hmap -F/bld/kakvim/src/MacVim/build/Release -F/bld/kakvim/src/MacVim -I/bld/kakvim/src/MacVim/build/Release/include -I/bld/kakvim/src/MacVim/build/MacVim.build/Release/MacVim.build/DerivedSources/ppc -I/bld/kakvim/src/MacVim/build/MacVim.build/Release/MacVim.build/DerivedSources -c /bld/kakvim/src/MacVim/MMAppController.m -o /bld/kakvim/src/MacVim/build/MacVim.build/Release/MacVim.build/Objects-normal/ppc/MMAppController.o
/bld/kakvim/src/MacVim/MMAppController.m: In function ‘-[MMAppController fileOpen:]’:
/bld/kakvim/src/MacVim/MMAppController.m:1100: error: ‘NSModalResponseOK’ undeclared (first use in this function)
/bld/kakvim/src/MacVim/MMAppController.m:1100: error: (Each undeclared identifier is reported only once
/bld/kakvim/src/MacVim/MMAppController.m:1100: error: for each function it appears in.)

I'm sure this also means it broke on Tiger.
@jpetrie
Copy link
Contributor

jpetrie commented May 29, 2015

In the related pull request I noted:

This will let somebody build a binary against older deployment targets if desired, but they'll still need the latest SDK (to see the appropriate availability macros). Is this sufficient or should I also take steps to make sure I check the SDK version somehow before doing the availability check? I don't really see this being done elsewhere, but MacVim.h does have a redefinition of the OS version macros up to 10.7; should I add the ones through 10.10 if I'm going to be using them?

I guess this is probably the consequence of the decision to merge the pull without redefining those additional availability macro definitions (MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_10 will be true because MAC_OS_X_VERSION_10_10 isn't defined in Leopard and the C preprocessor considers identifiers that are not defined macros within the context of an #if to be equivalent to 0 if -Wundef isn't set).

This will also break pull #38, which you were worried about. Explicitly redefining MAC_OS_X_VERSION_10_10 with appropriate values from the real AvailabilityMacros.h header should fix it, I believe. I'll add that change to #38.

@jpetrie jpetrie mentioned this issue May 29, 2015
Merged
@chdiza
Copy link
Contributor Author

chdiza commented Jul 12, 2015

I can confirm that the most recent commit (which amounts to Snapshot 77) has built on Tiger and Leopard. I see no problems yet.

@chdiza chdiza closed this as completed Jul 12, 2015
@douglasdrumond
Copy link
Member

Thanks!

Douglas Drumond
​​Café Linear http://www.cafelinear.com/ – GDG Campinas
http://www.gdg-campinas.org/​
google.com/+DouglasDrumond
http://google.com/+DouglasDrumond – @douglasdrumond
http://twitter.com/douglasdrumond​​

On Sun, Jul 12, 2015 at 1:59 AM, chdiza notifications@github.com wrote:

I can confirm that the most recent commit (which amounts to Snapshot 77)
has built on Tiger and Leopard. I see no problems yet.

—
Reply to this email directly or view it on GitHub
#40 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@douglasdrumond @jpetrie @chdiza