Make mvim smarter about remote logins #340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every now and then I need to ssh to an osx machine. Given that I have following aliases defined:
I can't easily launch MacVim in terminal. Instead, a window opens on the remote machine, I smack my forehead, kill it, unalias
vi
and use that. One workaround is to have vi/vim/vimdiff symlinks in place, that will affectargv0
and makemvim
launch in terminal. This solution is suboptimal though - when I'm logged in directly, I actually like having MacVim launch the gui version forvim
(muscle memory is a horrible thing to change). The shell I'm using (zsh
) allows forargv0
manipulation, butmvim
is a shell script, and$0
it is using is unaffected by those kind of manipulations.This small patch to mvim makes it skip the
-g
flag ifSSH_CONNECTION
environment variable is present. Doing it this way has the extra benefit of working seamlessly withtmux
, as by default it'll addSSH_CONNECTION
flag to newly created windows if you attach a session after sshing in.