Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mvim script's finding of MacVim.app #2

Merged
merged 3 commits into from Apr 27, 2015
Merged

Improve mvim script's finding of MacVim.app #2

merged 3 commits into from Apr 27, 2015

Conversation

chdiza
Copy link
Contributor

@chdiza chdiza commented Mar 15, 2015

For some reason, the mvim script had "/Applications" as the seventh item in the list of places to look for MacVim.app. Given that the overwhelming majority of all users are bound to have MacVim.app in /Applications, put it first in the list.

Also, eliminate a needlessly long line by making an array out of the places to check.

"/Applications", which is where 99.9% of all users will have
their MacVim.app located, was the seventh item to be checked for
the presence of MacVim.app.
@chdiza
Copy link
Contributor Author

chdiza commented Mar 15, 2015

Probably the items in the list after the fourth one should be removed, since it's hard to imagine someone actually puts MacVim.app there. But I left them in for backward compatibility.

EDIT: I meant to say, the entries of the form "*/vim"; I suspect those are cruft from the days of the Carbon gui.

@douglasdrumond
Copy link
Member

Thank you @chdiza, I'm a bit busy doing overtime work this weekend, but as soon as I can I'll look into it and merge.

@chdiza
Copy link
Contributor Author

chdiza commented Apr 25, 2015

ping

douglasdrumond added a commit that referenced this pull request Apr 27, 2015
Improve mvim script's finding of MacVim.app
@douglasdrumond douglasdrumond merged commit 726561f into macvim-dev:master Apr 27, 2015
@chdiza chdiza deleted the improvemvim branch April 27, 2015 19:38
@tko
Copy link

tko commented May 29, 2015

The relative priorities seem wrong to me in the new script; if you have MacVim.app both in ~/Applications and /Applications or any other case user vs. system directory conflict the user installation should have precedence IMO.

@chdiza
Copy link
Contributor Author

chdiza commented May 30, 2015

It's officially advised to not have two copies of MacVim on one's machine. Having two copies has been the cause of plenty of weirdness over the years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants