Thanks. Could you test #175?

Perfect. Thanks. I'm looking forward it to be merged ;-)

🎊

Shouldn't this have been solved by using :redraw! instead of :redraw, rather than chaning MacVim source?

Plain Vim doesn't behave in the way that this commit (and #182) make MacVim behave.

Shouldn't this have been solved by using :redraw! instead of :redraw, rather than chaning MacVim source?

I don't think so. I tried redraw! but using redraw! in for loop makes screen blinking.

Vim help said.

                            *:redr* *:redraw*
:redr[aw][!]        Redraw the screen right now.  When ! is included it is
            cleared first.
            Useful to update the screen halfway executing a script
            or function.  Also when halfway a mapping and
            'lazyredraw' is set.

So redraw and redraw! is a bit different.
I tinkg calling gui_macvim_flush_force after redraw or redrawstatus is a correct behavior.

but using redraw! in for loop makes screen blinking

But that's how plain Vim works.

Also, the flush_force version of this repair makes for a blinking cursor upon :redraw, when it didn't previously blink.

The docs show that :redraw isn't supposed to completely clear and then redraw the screen. That's what :redraw! is for.

But that's how plain Vim works.

No. At least in Vim on Ubuntu, GVim on Ubuntu, or Vim on Mac, the screen does not blink when I call :redraw but redraw!. So you cannot use redraw! instead of redraw. It's different.

https://gist.github.com/lambdalisue/94d14ff706a5627d64f5

The docs show that :redraw isn't supposed to completely clear and then redraw the screen. That's what :redraw! is for.

No. :redraw! stands for to clear first. redraw should also redraw the screen whenever called as well but without clearing (thus the screen won't blink).

I'm not sure if calling gui_macvim_flush_force is a correct way but I'm sure that the previous behavior is way different from other Vim.

And actually I noticed that redraw! did not work as well in revision ddc5c14 the one before the fix.

No. :redraw! stands for to clear first. redraw should also redraw the screen whenever called as well but without clearing (thus the screen won't blink).

That's what I said. :redraw is not for clearing first, :redraw! is for clearing first.

@chdiza your comment "Plain Vim doesn't behave in the way that this commit (and #182) make MacVim behave. " is useless. Please provide a concrete reproduction scenario like https://gist.github.com/lambdalisue/94d14ff706a5627d64f5.

At the very least, if I take that gist and :source it and run Test2, the behavor is different in MacVim and plain Vim. In plain Vim (i.e., from github.com/vim/vim, /usr/local/bin -u NONE -N), I see the countdown from 99 echoed by single digits. In MacVim (mvim -u NONE -U NONE -N) I see nothing at all echoed. It should work in both MacVim and plain Vim. If I run MacVim in the console, it behaves like plain Vim.

Now I got. Yes it seems an issue on redraw! but redraw. It is a quite strange behavior ... I didn't notice.

It didn't do that prior to the flush tweaks. I don't have time right now to see whether it was introduced in the flush or the force_flush change.

Expected behavior

Of https://gist.github.com/lambdalisue/94d14ff706a5627d64f5

Indicator is increasing 1 by 1 (E.g. Test: 1 -> Test: 2 -> ...) without blinking screen when Test 1 (redraw) is called.
Indicator is increasing 1 by 1 (E.g. Test: 1 -> Test: 2 -> ...) with blinking screen (because of screen flush) when Test 2 (redraw!) is called.

Actual behavior

Just before the redraw fix

revision: ddc5c14

Both Test1 and Test2 hung a bit and Test 99 is suddenly shown.

After the 1st redraw fix

revision: 2d3163f

Indicator is increasing 2 by 2 (Test: 1 -> Test: 3 -> ...) without blinking screen when Test 1 is called (almost correct behavior).
Nothing is shown when Test 2 is called.

After the 2nd redraw fix

revision: 05e488d

Indicator is increasing 1 by 1 (Test: 1 -> Test: 2 -> ...) without blinking screen when Test 1 is called (correct behavior).
Nothing is shown when Test 2 is called.

My conclusion

Both redraw and redraw! were broken and only redraw was fixed with recent commits. So reverting the commits won't fix the problem and further workarounds are required I guess. But I'm not really familiar with the code of Vim nor MacVim so I have no idea how :-p

It didn't do that prior to the flush tweaks

Let us know the revision. For me, this issue exists from when I started to use MacVim (several years ago). You may know the revision which works fine for redraw! workaround and that might help to resolve the issue.

How did I change the revision (in case)

I add :revision => "xxx" to brew edit macvim and re-installed.

head "https://github.com/macvim-dev/macvim.git", :revision => "ddc5c14"

with blinking screen (because of screen flush) when Test 2 (redraw!) is called.

Why is a blinking screen expected in this case? It doesn't blink in plain Vim when I call Test2.

because it clear the screen. try with fullscreen mode and/or a slow machine. prob your GPU is too fast to recognise i guess.